From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756012AbcEXMWK (ORCPT ); Tue, 24 May 2016 08:22:10 -0400 Received: from mail-am1on0118.outbound.protection.outlook.com ([157.56.112.118]:9511 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753895AbcEXMWH (ORCPT ); Tue, 24 May 2016 08:22:07 -0400 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=virtuozzo.com; Date: Tue, 24 May 2016 15:21:58 +0300 From: Vladimir Davydov To: Michal Hocko CC: Andrew Morton , Tetsuo Handa , , Subject: Re: [PATCH] mm: oom: do not reap task if there are live threads in threadgroup Message-ID: <20160524122158.GK7917@esperanza> References: <1464087628-7318-1-git-send-email-vdavydov@virtuozzo.com> <20160524114612.GG8259@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160524114612.GG8259@dhcp22.suse.cz> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM2PR09CA0010.eurprd09.prod.outlook.com (2a01:111:e400:841f::20) To AM3PR08MB0579.eurprd08.prod.outlook.com (2a01:111:e400:c408::13) X-MS-Office365-Filtering-Correlation-Id: c223e760-9607-4a78-55ce-08d383ce03c2 X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0579;2:z606yQl6FYIWNTBakEcpoUdmnF8ABnSiA7C8sXsqG1URN4c1adWgB5669+OOQ8VndM9vxveI03G0uavUE7+gvbXmvCPpNc/Nosgex+js0Y7wGjNUxx48I3i7yNW/GR3Qd8nrb3jKoD+3iuIQVHBMQrsbPv90n+CtDYGPwU1FXQseDxSEy9sIOjrMBTnu8tEs;3:+1K19R19v46WQDDpBT2++Ubp1HoaMjmtWfCMFS7uUb50pZ93SRqTozXgdmC5rfU5GTB6oMpAHmhJ0AUYBU/GGH+OWlGzsXEGb7enP1N9rBdywITIG32YThpTXUSFDPqG;25:9Kmw+g71lyeGH0YrfA5qjxBTveqrdmdpUzatpKCJfflwP9JZHMCV3tiFoxGnerxvUDlNMv86RrxvaBpGDWgiHNXSxLr25pecLzQJY/ID92qCLqqrbekqBp7y2/ypIl2J45oRh01D/wsjir9pLO+F2ECxtDZnlbawRuKf7NhoqTmaTRmZN1la+WmUIfEnO9Ln9wssukjE48Vx6xXoLPlVVXBlNpx9+iFTQKLw6kQbTHp+/1EaHaMpE6FI59xanpZ1dtvr+1ytUpENEUVf51vlSS861ViGSERhMdF5zkjPRLT/2oqEpFr+4+ZJuNm21xuG5RncQvbAHznS/eyWjoz3tm8TIYG+iK0lmneqF48wqfM7o+ZPNmPuxMdIdga/D+hNF2xS2j+Y+U16CHQAmLgI0kXgFb/+vOyWse8FjLI1/qc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0579; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:AM3PR08MB0579;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0579; X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0579;4:WUHPZhBPG6xscN/COVBSiQw87To3ZduEOITFZ945auZoldMo2cRFoN0SO/2SyRlubigXLdD8XpHXwKLnwXA41sE+/tJmC3OnJhSFiv3K/GHhYpm9Q/wDygkkN9V0op94IXu3uGFUkk98s1l1BqRdZUj/30AIfCpqwuZNnsb4QjyzucOGG77UCkXyPK4oW3B+JEpDJuJIQQsRZsgjCLan0uoNEwTdegldqLO3IjJj1uyb0tELCSg1LnsEcoDl3RWAt8ORvCZDdJpsAmpHRD4IwKlCkny5yotvGQZDmdS27VkDd78ltDpUm2MjEAW1BfW5QvsoVd+y8Acf3M3xX/BKEsinqeRxdN1wIYS89+1oVrK6mvBircKqljt9O+lE3aHsqa3uTNjt4Qd7VXo9IE1930q8UtEQEt75F+SDjlzsq/s= X-Forefront-PRVS: 09525C61DB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(377424004)(24454002)(50466002)(5004730100002)(23726003)(4326007)(586003)(6116002)(3846002)(2906002)(9686002)(42186005)(80792005)(189998001)(1076002)(110136002)(2950100001)(19580395003)(19580405001)(47776003)(76176999)(50986999)(66066001)(33716001)(46406003)(86362001)(97756001)(54356999)(81166006)(8676002)(5008740100001)(92566002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM3PR08MB0579;H:esperanza;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0579;23:bzTwyPlrtEg32xYClSJ28q/pPaRZt1Dh1nQRMp9lzADpokBrIYJwGqFFiOoqvRRbgFw2ocxvlot5LBnnf3e8oA8SmSmN1R+x+vx5Qc7kkP9M7AfJJiHyBhNBjy53asCGCYX1v22i4bOiZTsWuQxzYX40MTPAL+TSLZFUpkgs7dmG8el4bVWAte3gdRDzzPWe9vi9XllEEN/Rpqqa8l+wLYhkMJdas76b3+bODJ/z1T0uerDjaqrxAFY8CnUx8JB0pmK5V3Tijfm+stcxxKx/m4csYL8D7llAkcS+1FwNa6WnqtCYly6VTmAKdXpd3sQdiLGdZbXSFzUQEtojtiLbmmfsH28Gbh4/jxCTXYWw1zis9Qz94TNUyupiuTwmYWq0xoTA24HV/nNSSQ4QiGJ+M3DcOMEGY3rAVtARSNJewLRA47k5mTxfgdkBxMxGSpaalE5EmTKj2W0rPTxS2oy93A9ZH+jq7cTBKvdbdx4SKdKxinrUTNC/8CTMsZ+lqZ/6o40Jmxc0vrZQqEPUE8UbQ98Wy8jd+/IrgYrz1pFxrBs6A0k/RtYPC2Rm44+SbwwATLkR8uge3O0i/VUI3uVpEoFEYASSNjmjvAuOljV7YNdWf8KsWv8Z9L0X1jpyrzcrmSaprCXCRWi4VwsUqj2ufdZ1gxlMYxHgyGAAhCYPdpPyuwjrvlgmHoltlyHmNt1hmCsEvoxuLoa6oRm8LZsWU6sUT2SIKxvwJprDc089Wovz08eZhBlekfQBIKjDJw7H0g+QqwLQ4qMQuD1KzI3rAiyfAszespjCU8O1yax5nvOwYlrPdpGmFd/qpLbqvW/EKXPm2V0NlRHWYtI30CCDWAdHTRCNF8ovF7Dmj28C0q0N2fMI4Kh+k3aSIRDLbgV4rRhKMnq8z5z6l0cY8vlgPD1LzWNf80gqrm2nzkaPy64= X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0579;5:ORSdJ95hf+uQgybUyiZjJylZN3iMlVuKfyDBIsOU65Daj5Lhh5wGgJI+IhcKwqb+Chpm7Qd0kZwbRqSMMaETFZ60r3oplWKLVCnP4P0ZeNSS1aGxwPOoh8QDbjNVQScd7h/TD8NlyUZ8vyhcafuNhQ==;24:ejhAp12sOQlkojqUXOIRhzN+JC0drwEf3wghaDyK0bBXr3UDyatzwQ1OIHe1RAgr530p2WNaC8zwzmZxd1cF0jb0vLHeByAyFq5Zo678CYM=;7:Un8dzZyrcBSmWoJ5xavjx9IY4i2tLgHL7RXPsOnimoJVcqt19doXvKyTiXjEad1inPGQNRVeIWl8xgUdpNe3uoAWuamo9mCj3ygcjhbf+od1BHCKcLA68egLr/bZXfJKqnc6LPtXWKnSf9XuwWt2zMFq9rIdEBMFhvCicN1LzJ/ZOSY4U12QT0w13qYtY7Bo;20:hAKsnmpHwIwQRQsJtIKoUTFa9/9SFDMsZKT2lLNPmwHoaMQHpIRmj40ukvQ3+0T8zRzU6sgucfLx9eNvawnPrHzCjbdoSaoBtMfv1DEY39P/1t1jMExyvnt7/2QX5ALoAQ8afFosFeiPM0M8++OlWsw8cVivGjuQ7deASM+Fmck= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2016 12:22:03.3315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0579 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2016 at 01:46:12PM +0200, Michal Hocko wrote: > On Tue 24-05-16 14:00:28, Vladimir Davydov wrote: > > If the current process is exiting, we don't invoke oom killer, instead > > we give it access to memory reserves and try to reap its mm in case > > nobody is going to use it. There's a mistake in the code performing this > > check - we just ignore any process of the same thread group no matter if > > it is exiting or not - see try_oom_reaper. Fix it. > > This is not a problem with the current code because of 98748bd72200 > ("oom: consider multi-threaded tasks in task_will_free_mem") which got > merged later on, however. True, I missed that patch. > > The check is not needed so we can indeed drop it. > > Fixes: 3ef22dfff239 ("oom, oom_reaper: try to reap tasks which skip > regular OOM killer path") > > Just in case somebody wants to backport only 3ef22dfff239. > > > Signed-off-by: Vladimir Davydov > > Acked-by: Michal Hocko Thanks.