public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: changbin.du@intel.com
Cc: mathias.nyman@linux.intel.com, stefan.koch10@gmail.com,
	hkallweit1@gmail.com, sergei.shtylyov@cogentembedded.com,
	jonas.hesselmann@hotmail.de, mingo@kernel.org,
	paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org,
	tglx@linutronix.de, keescook@chromium.org,
	dan.j.williams@intel.com, aryabinin@virtuozzo.com, tj@kernel.org,
	dave@stgolabs.net, nikolay@cumulusnetworks.com,
	dvyukov@google.com, adrien+dev@schischi.me,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: core: add debugobjects support for urb object
Date: Tue, 24 May 2016 07:44:59 -0700	[thread overview]
Message-ID: <20160524144459.GD28161@kroah.com> (raw)
In-Reply-To: <1464076433-3284-1-git-send-email-changbin.du@intel.com>

On Tue, May 24, 2016 at 03:53:53PM +0800, changbin.du@intel.com wrote:
> From: "Du, Changbin" <changbin.du@intel.com>
> 
> Add debugobject support to track the life time of struct urb.
> This feature help us detect violation of urb operations by
> generating a warning message from debugobject core. And we fix
> the possible issues at runtime to avoid oops if we can.
> 
> I have done some tests with some class drivers, no violation
> found in them which is good. Expect this feature can be used
> for debugging future problems.
> 
> Signed-off-by: Du, Changbin <changbin.du@intel.com>

I agree with Alan, what use is this code?  Existing drivers all work
properly because the reference counting of urbs is already present, why
add duplicate counters?  That actually leads to bugs.  I don't see the
need for this code, please explain it better if you wish for it to be
accepted.  What has it found/fixed that we have not found yet?  What
does it allow you to do that you can't do today with the existing code?

thanks,

greg k-h

  parent reply	other threads:[~2016-05-24 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24  7:53 [PATCH] usb: core: add debugobjects support for urb object changbin.du
2016-05-24 14:23 ` Alan Stern
2016-05-24 14:44 ` Greg KH [this message]
2016-05-26  2:15   ` Du, Changbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160524144459.GD28161@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adrien+dev@schischi.me \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=changbin.du@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave@stgolabs.net \
    --cc=dvyukov@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jonas.hesselmann@hotmail.de \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mingo@kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=stefan.koch10@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox