From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755132AbcEXLyn (ORCPT ); Tue, 24 May 2016 07:54:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53119 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbcEXLym (ORCPT ); Tue, 24 May 2016 07:54:42 -0400 Date: Tue, 24 May 2016 14:54:37 +0300 From: "Michael S. Tsirkin" To: Jesper Dangaard Brouer Cc: linux-kernel@vger.kernel.org, Jason Wang , Eric Dumazet , davem@davemloft.net, netdev@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH v5 2/2] skb_array: ring test Message-ID: <20160524145333-mutt-send-email-mst@redhat.com> References: <1464000201-15560-1-git-send-email-mst@redhat.com> <1464000201-15560-3-git-send-email-mst@redhat.com> <20160523150918.2c58fa7d@redhat.com> <20160523235014-mutt-send-email-mst@redhat.com> <20160524122809.140f7020@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160524122809.140f7020@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 24 May 2016 11:54:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2016 at 12:28:09PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 23 May 2016 23:52:47 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, May 23, 2016 at 03:09:18PM +0200, Jesper Dangaard Brouer wrote: > > > On Mon, 23 May 2016 13:43:46 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Add ringtest based unit test for skb array. > > > > > > > > Signed-off-by: Michael S. Tsirkin > > > > --- > > > > tools/virtio/ringtest/skb_array.c | 167 ++++++++++++++++++++++++++++++++++++++ > > > > tools/virtio/ringtest/Makefile | 4 +- > > > > > > Patch didn't apply cleanly to Makefile, as you also seems to have > > > "virtio_ring_inorder", I manually applied it. > > > > > > I chdir to tools/virtio/ringtest/ and I could compile "skb_array", > > > BUT how do I use it??? (the README is not helpful) > > > > > > What is the "output", are there any performance measurement results? > > > > First, if it completes successfully this means it completed > > a ton of cycles without errors. It caches any missing barriers > > which aren't nops on your system. > > I applied these patches on net-next (at commit 07b75260e) and the > skb_array test program never terminates. Strangely if I use your git > tree[1] (on branch vhost) the program does terminate... I didn't spot > the difference. Oh, that's my bad. You need ringtest: pass buf != NULL just a stub pointer for now. Signed-off-by: Michael S. Tsirkin from my tree. -- MST