From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756385AbcEXPcO (ORCPT ); Tue, 24 May 2016 11:32:14 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35128 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754806AbcEXPcJ (ORCPT ); Tue, 24 May 2016 11:32:09 -0400 Date: Tue, 24 May 2016 17:32:06 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Ivaylo Dimitrov , sre@kernel.org Cc: dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek Subject: Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Message-ID: <20160524153206.GU29844@pali> References: <1451646209-11618-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <201601011226.21552@pali> <201601092342.30608@pali> <20160519091304.GK29844@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160519091304.GK29844@pali> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 19 May 2016 11:13:04 Pali Rohár wrote: > On Saturday 09 January 2016 23:42:30 Pali Rohár wrote: > > On Friday 01 January 2016 12:26:21 Pali Rohár wrote: > > > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote: > > > > All calls to isp1704_write() are using parameter sequence of > > > > isp1704_write(isp, reg, val) but the function is defined as > > > > isp1704_write(isp, val, reg). Fix isp1704_write function definition > > > > so that the driver to be functional. > > > > > > > > Signed-off-by: Ivaylo Dimitrov > > > > > > Reviewed-by: Pali Rohár > > > > > > This problem is there since inclusion of driver itself. No idea why > > > that driver could work... I remember that it detected correctly type > > > of charger. > > > > > > I will test this patch on real N900 HW in one or two weeks to check > > > how it behave after patching... > > > > Tested-by: Pali Rohár > > > > Please send this patch to all stable kernels. > > Hi! I still think that this patch should go to stable kernels. Because > without it driver does not work... Will somebody send it to stable? So no objections, I sent it to stable@vger.kernel.org. -- Pali Rohár pali.rohar@gmail.com