From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755230AbcEXQ65 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 May 2016 12:58:57 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:53535 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751527AbcEXQ64 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 May 2016 12:58:56 -0400
Date: Tue, 24 May 2016 18:58:36 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Manfred Spraul <manfred@colorfullife.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Will Deacon <will.deacon@arm.com>, Boqun Feng <boqun.feng@gmail.com>,
        Waiman Long <Waiman.Long@hpe.com>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        Patrick McHardy <kaber@trash.net>, David Miller <davem@davemloft.net>,
        Oleg Nesterov <oleg@redhat.com>, netfilter-devel@vger.kernel.org,
        Sasha Levin <sasha.levin@oracle.com>, hofrat@osadl.org
Subject: Re: [RFC][PATCH 2/3] locking: Annotate spin_unlock_wait() users
Message-ID: <20160524165836.GC15189@worktop.bitpit.net>
References: <20160524142723.178148277@infradead.org>
 <20160524143649.608476390@infradead.org>
 <CA+55aFyyHbPVMx8cZbKONy5cevxsYA0qbwapboA0dD8hPSwPWg@mail.gmail.com>
 <20160524162207.GB3354@mtj.duckdns.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160524162207.GB3354@mtj.duckdns.org>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 24, 2016 at 12:22:07PM -0400, Tejun Heo wrote:
> A delta but that particular libata usage is probably not needed now.
> The path was used while libata was gradually adding error handlers to
> the low level drivers.  I don't think we don't have any left w/o one
> at this point.  I'll verify and get rid of that usage.

OK, that would be great; I was sorta lost in there, but it looked like
if you need the spin_unlock_wait() you also need the extra barrier
thing.

If you can remove it, better still.