public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dave Jones <davej@codemonkey.org.uk>,
	kernel test robot <fengguang.wu@intel.com>,
	Borislav Petkov <bp@suse.de>, LKP <lkp@01.org>,
	oprofile-list@lists.sf.net, linux-kernel@vger.kernel.org,
	wfg@linux.intel.com
Subject: Re: [x86/cpufeature] 7b5e74e637:  BUG: unable to handle kernel paging request at 6b636170
Date: Wed, 25 May 2016 08:28:15 +0200	[thread overview]
Message-ID: <20160525062815.GA31368@gmail.com> (raw)
In-Reply-To: <20160524200709.GA9079@codemonkey.org.uk>


* Dave Jones <davej@codemonkey.org.uk> wrote:

> On Wed, May 25, 2016 at 03:58:10AM +0800, kernel test robot wrote:
>  
>  > 0day kernel testing robot got the below dmesg and the first bad commit is
>  > 
>  > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>  > 
>  > commit 7b5e74e637e4a977c7cf40fd7de332f60b68180e
>  > Author:     Borislav Petkov <bp@suse.de>
>  > AuthorDate: Tue Mar 29 17:41:54 2016 +0200
>  > Commit:     Ingo Molnar <mingo@kernel.org>
>  > CommitDate: Thu Mar 31 13:33:17 2016 +0200
>  > 
>  >     x86/cpufeature: Remove cpu_has_arch_perfmon
>  >     
>  >     Use boot_cpu_has() instead.
> 
> This seem an unlikely candidate given...
> 
>  > [    1.914984] random: trinity urandom read with 25 bits of entropy available
>  > [    8.542178] random: nonblocking pool is initialized
>  > [   11.939833] sock: process `trinity-main' is using obsolete setsockopt SO_BSDCOMPAT
>  > [   12.349890] BUG: unable to handle kernel paging request at 6b636170
>  > [   12.349895] IP: [<c108154b>] perf_prepare_sample+0x7d/0x263
> 
> The trace is more related to perf.

Also, 7b5e74e637e4a appears to be pretty much a provable NOP, it should not change 
a single byte in the kernel image, as it replaces a macro use:

-#define cpu_has_arch_perfmon   boot_cpu_has(X86_FEATURE_ARCH_PERFMON)

... with open-coded expressions of the same.

Thanks,

	Ingo

      parent reply	other threads:[~2016-05-25  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 19:58 [x86/cpufeature] 7b5e74e637: BUG: unable to handle kernel paging request at 6b636170 kernel test robot
2016-05-24 20:07 ` Dave Jones
2016-05-25  0:54   ` Fengguang Wu
2016-05-25  6:28   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160525062815.GA31368@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@suse.de \
    --cc=davej@codemonkey.org.uk \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=oprofile-list@lists.sf.net \
    --cc=wfg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox