From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbcEYG6H (ORCPT ); Wed, 25 May 2016 02:58:07 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:43087 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752409AbcEYG6F (ORCPT ); Wed, 25 May 2016 02:58:05 -0400 X-Greylist: delayed 563 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 May 2016 02:58:04 EDT Date: Wed, 25 May 2016 09:48:32 +0300 From: Baruch Siach To: Masahiro Yamada Cc: linux-gpio@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Message-ID: <20160525064832.GG2178@tarshish> References: <1464155932-25344-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464155932-25344-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro Yamada, On Wed, May 25, 2016 at 02:58:52PM +0900, Masahiro Yamada wrote: > gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither > platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver. > > Signed-off-by: Masahiro Yamada Acked-by: Baruch Siach Thanks, baruch > drivers/pinctrl/pinctrl-digicolor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c > index 30ee564..c8073d4 100644 > --- a/drivers/pinctrl/pinctrl-digicolor.c > +++ b/drivers/pinctrl/pinctrl-digicolor.c > @@ -332,6 +332,8 @@ static int dc_pinctrl_probe(struct platform_device *pdev) > return PTR_ERR(pmap->pctl); > } > > + platform_set_drvdata(pdev, pmap); > + > return dc_gpiochip_add(pmap, pdev->dev.of_node); > } -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -