From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752235AbcEYWXW (ORCPT ); Wed, 25 May 2016 18:23:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41879 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbcEYWXV (ORCPT ); Wed, 25 May 2016 18:23:21 -0400 Date: Wed, 25 May 2016 15:23:19 -0700 From: Andrew Morton To: Yang Shi Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH] mm: use early_pfn_to_nid in register_page_bootmem_info_node Message-Id: <20160525152319.fa87b4cc0b8326fef89a1b92@linux-foundation.org> In-Reply-To: <1464210007-30930-1-git-send-email-yang.shi@linaro.org> References: <1464210007-30930-1-git-send-email-yang.shi@linaro.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 May 2016 14:00:07 -0700 Yang Shi wrote: > register_page_bootmem_info_node() is invoked in mem_init(), so it will be > called before page_alloc_init_late() if CONFIG_DEFERRED_STRUCT_PAGE_INIT > is enabled. But, pfn_to_nid() depends on memmap which won't be fully setup > until page_alloc_init_late() is done, so replace pfn_to_nid() by > early_pfn_to_nid(). What are the runtime effects of this fix?