From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756106AbcEYRhb (ORCPT ); Wed, 25 May 2016 13:37:31 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36065 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755531AbcEYRh3 (ORCPT ); Wed, 25 May 2016 13:37:29 -0400 Date: Wed, 25 May 2016 10:37:24 -0700 From: Nicolin Chen To: Rob Herring Cc: broonie@kernel.org, brian.austin@cirrus.com, Paul.Handrigan@cirrus.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, lgirdwood@gmail.com, Tim.Howe@cirrus.com, somduttar@nvidia.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v6] ASoC: cs53l30: Add codec driver support for Cirrus CS53L30 Message-ID: <20160525173724.GA20293@Asurada-Nvidia> References: <1464045237-4074-1-git-send-email-nicoleotsuka@gmail.com> <20160525172800.GB3056@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160525172800.GB3056@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 12:28:00PM -0500, Rob Herring wrote: > > diff --git a/Documentation/devicetree/bindings/sound/cs53l30.txt b/Documentation/devicetree/bindings/sound/cs53l30.txt > > new file mode 100644 > > index 0000000..ace7ffe > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/cs53l30.txt > > @@ -0,0 +1,38 @@ > > +CS53L30 audio CODEC > > + > > +Required properties: > > + > > + - compatible : "cirrus,cs53l30" > > + > > + - reg : the I2C address of the device > > + > > + - VA-supply, VP-supply : power supplies for the device, > > + as covered in Documentation/devicetree/bindings/regulator/regulator.txt. > Also, these are missing from the example yet are required. I'd argue > they should be optional as you could have designs with no regulator > control. Will refine both in next ver. Thanks