Re: [PATCH v6] ASoC: cs53l30: Add codec driver support for Cirrus CS53L30

Nicolin Chen
2016-05-25T17:37:31Z

On Wed, May 25, 2016 at 12:28:00PM -0500, Rob Herring wrote:

> > diff --git a/Documentation/devicetree/bindings/sound/cs53l30.txt b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > new file mode 100644
> > index 0000000..ace7ffe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > @@ -0,0 +1,38 @@
> > +CS53L30 audio CODEC
> > +
> > +Required properties:
> > +
> > + - compatible : "cirrus,cs53l30"
> > +
> > + - reg : the I2C address of the device
> > +
> > + - VA-supply, VP-supply : power supplies for the device,
> > + as covered in Documentation/devicetree/bindings/regulator/regulator.txt.

> Also, these are missing from the example yet are required. I'd argue
> they should be optional as you could have designs with no regulator
> control.

Will refine both in next ver. Thanks