From: Bin Liu <b-liu@ti.com>
To: Andrew Goodbody <andrew.goodbody@cambrionix.com>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 0/2] usb: musb: fix dropped packets
Date: Wed, 25 May 2016 15:07:53 -0500 [thread overview]
Message-ID: <20160525200753.GA27089@uda0271908> (raw)
In-Reply-To: <1464078154-13157-1-git-send-email-andrew.goodbody@cambrionix.com>
Hi,
On Tue, May 24, 2016 at 09:22:32AM +0100, Andrew Goodbody wrote:
> The musb driver can drop rx packets when heavily loaded. These two
> patches address two issues that can cause this. Both issues arose
> when an endpoint was reprogrammed. The first patch is a logic bug
> that resulted in a shared_fifo in rx mode not having its state
> cleared out. The second patch fixes a race condition caused by
> not stopping the dedicated endpoint for bulk packets before
> rotating its queue which allowed a packet to be recieved and then
> thrown away.
>
> V3 Updated the comment to better reference the manual
> V2 added a comment and removed debugging code
>
> Andrew Goodbody (2):
> usb: musb: Ensure rx reinit occurs for shared_fifo endpoints
> usb: musb: Stop bulk endpoint while queue is rotated
Signed-off-by: Bin Liu <b-liu@ti.com>
Regards,
-Bin.
>
> drivers/usb/musb/musb_host.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2016-05-25 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 8:22 [PATCH V3 0/2] usb: musb: fix dropped packets Andrew Goodbody
2016-05-24 8:22 ` [PATCH V3 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints Andrew Goodbody
2016-05-24 8:22 ` [PATCH V3 2/2] usb: musb: Stop bulk endpoint while queue is rotated Andrew Goodbody
2016-05-25 20:07 ` Bin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525200753.GA27089@uda0271908 \
--to=b-liu@ti.com \
--cc=andrew.goodbody@cambrionix.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox