From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbcEYUH7 (ORCPT ); Wed, 25 May 2016 16:07:59 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:46457 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbcEYUH6 (ORCPT ); Wed, 25 May 2016 16:07:58 -0400 Date: Wed, 25 May 2016 15:07:53 -0500 From: Bin Liu To: Andrew Goodbody CC: , , Subject: Re: [PATCH V3 0/2] usb: musb: fix dropped packets Message-ID: <20160525200753.GA27089@uda0271908> Mail-Followup-To: Bin Liu , Andrew Goodbody , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <1464078154-13157-1-git-send-email-andrew.goodbody@cambrionix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1464078154-13157-1-git-send-email-andrew.goodbody@cambrionix.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, May 24, 2016 at 09:22:32AM +0100, Andrew Goodbody wrote: > The musb driver can drop rx packets when heavily loaded. These two > patches address two issues that can cause this. Both issues arose > when an endpoint was reprogrammed. The first patch is a logic bug > that resulted in a shared_fifo in rx mode not having its state > cleared out. The second patch fixes a race condition caused by > not stopping the dedicated endpoint for bulk packets before > rotating its queue which allowed a packet to be recieved and then > thrown away. > > V3 Updated the comment to better reference the manual > V2 added a comment and removed debugging code > > Andrew Goodbody (2): > usb: musb: Ensure rx reinit occurs for shared_fifo endpoints > usb: musb: Stop bulk endpoint while queue is rotated Signed-off-by: Bin Liu Regards, -Bin. > > drivers/usb/musb/musb_host.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > -- > 2.7.4 >