From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752137AbcEYVtm (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 May 2016 17:49:42 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:57248 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751205AbcEYVtl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 May 2016 17:49:41 -0400
Date: Wed, 25 May 2016 22:49:35 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Konstantin Khlebnikov <koct9i@gmail.com>,
        Andy Lutomirski <luto@amacapital.net>, Jan Kara <jack@suse.cz>,
        yalin wang <yalin.wang2010@gmail.com>, Willy Tarreau <w@1wt.eu>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9] fs: clear file privilege bits when mmap writing
Message-ID: <20160525214935.GI14480@ZenIV.linux.org.uk>
References: <20160114212201.GA28910@www.outflux.net>
 <CALYGNiNN+QYpd-FhM+4WXd=-1UYrhR7kpefbN8mpjh4gSbDO4A@mail.gmail.com>
 <CAGXu5j+cwZQfnSPQNjb=VVzZfJH8n=iZUCM+vz_a6nPku5tQ2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXu5j+cwZQfnSPQNjb=VVzZfJH8n=iZUCM+vz_a6nPku5tQ2g@mail.gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 25, 2016 at 02:36:57PM -0700, Kees Cook wrote:

> Hm, this didn't end up getting picked up. (This jumped out at me again
> because i_mutex just vanished...)
> 
> Al, what's the right way to update the locking in this patch?

->i_mutex is dealt with just by using lock_inode(inode)/unlock_inode(inode);
I hadn't looked at the rest of the locking in there.