From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752777AbcEZAc0 (ORCPT ); Wed, 25 May 2016 20:32:26 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36667 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbcEZAcX (ORCPT ); Wed, 25 May 2016 20:32:23 -0400 Date: Wed, 25 May 2016 17:13:50 -0700 From: "'Dmitry Torokhov'" To: =?utf-8?B?5buW5bSH5qau?= Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, zac.hsieh@emc.com.tw, =?utf-8?B?J+m7g+S4lum1rCDntpPnkIYn?= , "'Charles Mooney'" , "'Agnes Cheng'" , "'jeff'" Subject: Re: [PATCH] Emit BTN_TOO_FINGER in function input_mt_report_pointer_emulation if touchpad meets hover condition Message-ID: <20160526001350.GB22369@dtor-ws> References: <003101d1b67a$dce6e5c0$96b4b140$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <003101d1b67a$dce6e5c0$96b4b140$@emc.com.tw> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi KT, On Wed, May 25, 2016 at 07:44:57PM +0800, 廖崇榮 wrote: > Hi Dmitry, > > Update /input/mouse/input-mt.c > Emit BTN_TOO_FINGER in input_mt_report_pointer_emulation if touchpad meets hover condition. Please do not top-post and also do not send patches as attachments, they should be sent inline. Please take a look at "git send-email" command. Thanks. > > Thanks & BR KT > > -----Original Message----- > From: 'Dmitry Torokhov' [mailto:dmitry.torokhov@gmail.com] > Sent: Friday, May 20, 2016 8:52 AM > To: 廖崇榮 > Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; zac.hsieh@emc.com.tw; '黃世鵬 經理'; 'Charles Mooney'; 'Agnes Cheng'; 'jeff' > Subject: Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger > > On Tue, May 17, 2016 at 10:20:40PM +0800, 廖崇榮 wrote: > > Hi Dmitry, > > > > I want to confirm my thought for your idea to avoid misunderstanding. > > I think you want to encapsulate " BTN_TOOL_FINGER" in the [input_mt_report_pointer_emulation] if hover happen. > > Vendor driver only report "ABS_DISTANCE" and let [input_mt_report_pointer_emulation] emit BTN_TOOL_FINGER report without change function parameter. > > > > Please let me know if my misunderstand about your idea. > > Yes, that is correct. Something like this: > > diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c index 54fce56..a1bbec9 100644 > --- a/drivers/input/input-mt.c > +++ b/drivers/input/input-mt.c > @@ -218,8 +218,23 @@ void input_mt_report_pointer_emulation(struct input_dev *dev, bool use_count) > } > > input_event(dev, EV_KEY, BTN_TOUCH, count > 0); > - if (use_count) > + > + if (use_count) { > + if (count == 0 && > + !test_bit(ABS_MT_DISTANCE, dev->absbit) && > + test_bit(ABS_DISTANCE, dev->absbit) && > + input_abs_get_val(dev, ABS_DISTANCE) != 0) { > + /* > + * Force reporting BTN_TOOL_FINGER for devices that > + * only report general hover (and not per-contact > + * distance) when contact is in proximity but not > + * on the surface. > + */ > + count = 1; > + } > + > input_mt_report_finger_count(dev, count); > + } > > if (oldest) { > int x = input_mt_get_value(oldest, ABS_MT_POSITION_X); > > -- > Dmitry -- Dmitry