From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbcEZAn5 (ORCPT ); Wed, 25 May 2016 20:43:57 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:46295 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbcEZAn4 (ORCPT ); Wed, 25 May 2016 20:43:56 -0400 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.203 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 26 May 2016 09:44:12 +0900 From: Minchan Kim To: Sergey Senozhatsky CC: Andrew Morton , Joonsoo Kim , , Sergey Senozhatsky Subject: Re: [PATCH 1/7] zram: rename zstrm find-release functions Message-ID: <20160526004412.GC9661@bbox> References: <20160525143006.1207-1-sergey.senozhatsky@gmail.com> <20160525143006.1207-2-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 In-Reply-To: <20160525143006.1207-2-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/05/26 09:43:51, Serialize by Router on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/05/26 09:43:51, Serialize complete at 2016/05/26 09:43:51 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 11:30:00PM +0900, Sergey Senozhatsky wrote: > We don't perform any zstream idle list lookup anymore, so > zcomp_strm_find()/zcomp_strm_release() names are not > representative. > > Rename to zcomp_stream_get()/zcomp_stream_put(). Actually, I wanted it when we applied percpu but didn't say to you because 1. It's preference of author. Frankly speaking, I prefer get to find but you might think different with me so I want to respect patch author's right if it's not huge pain to me. :) Now I realized you were on same page. 2. We might roll back to stream list. In that case, find is proper word again but it's too trivial. So, I want to merge this patch regardless of this patchset. :) > > Signed-off-by: Sergey Senozhatsky > Cc: Minchan Kim Acked-by: Minchan Kim