From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
<linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 0/7] zram: switch to crypto api
Date: Thu, 26 May 2016 09:52:32 +0900 [thread overview]
Message-ID: <20160526005232.GD9661@bbox> (raw)
In-Reply-To: <20160525143006.1207-1-sergey.senozhatsky@gmail.com>
On Wed, May 25, 2016 at 11:29:59PM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> This has started as a 'add zlib support' work, but after some
> thinking I saw no blockers for a bigger change -- a switch to
> crypto API.
>
> We don't have an idle zstreams list anymore and our write path
> now works absolutely differently, preventing preemption during
> compression. This removes possibilities of read paths preempting
> writes at wrong places and opens the door for a move from custom
> LZO/LZ4 compression backends implementation to a more generic one,
> using crypto compress API.
>
> This patch set also eliminates the need of a new context-less
> crypto API interface, which was quite hard to sell, so we can
> move along faster.
Super fast Sergey.
At a first glance, patchset looks nice.
I will review as soon as possible.
Thanks a lot!
>
>
> Sergey Senozhatsky (7):
> zram: rename zstrm find-release functions
> zram: switch to crypto compress API
> zram: drop zcomp param from compress/decompress
> zram: align zcomp interface to crypto comp API
> zram: use crypto api to check alg availability
> zram: delete custom lzo/lz4
> zram: add more compression algorithms
>
> drivers/block/zram/Kconfig | 15 +------
> drivers/block/zram/Makefile | 4 +-
> drivers/block/zram/zcomp.c | 91 +++++++++++++++++++++++++++---------------
> drivers/block/zram/zcomp.h | 29 ++++----------
> drivers/block/zram/zcomp_lz4.c | 56 --------------------------
> drivers/block/zram/zcomp_lz4.h | 17 --------
> drivers/block/zram/zcomp_lzo.c | 56 --------------------------
> drivers/block/zram/zcomp_lzo.h | 17 --------
> drivers/block/zram/zram_drv.c | 26 +++++++-----
> 9 files changed, 84 insertions(+), 227 deletions(-)
> delete mode 100644 drivers/block/zram/zcomp_lz4.c
> delete mode 100644 drivers/block/zram/zcomp_lz4.h
> delete mode 100644 drivers/block/zram/zcomp_lzo.c
> delete mode 100644 drivers/block/zram/zcomp_lzo.h
>
> --
> 2.8.3.394.g3916adf
>
next prev parent reply other threads:[~2016-05-26 0:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 14:29 [PATCH 0/7] zram: switch to crypto api Sergey Senozhatsky
2016-05-25 14:30 ` [PATCH 1/7] zram: rename zstrm find-release functions Sergey Senozhatsky
2016-05-26 0:44 ` Minchan Kim
2016-05-26 1:07 ` Sergey Senozhatsky
2016-05-25 14:30 ` [PATCH 2/7] zram: switch to crypto compress API Sergey Senozhatsky
2016-05-27 4:22 ` Minchan Kim
2016-05-27 7:59 ` Sergey Senozhatsky
2016-05-25 14:30 ` [PATCH 3/7] zram: drop zcomp param from compress/decompress Sergey Senozhatsky
2016-05-27 4:22 ` Minchan Kim
2016-05-27 7:31 ` Sergey Senozhatsky
2016-05-25 14:30 ` [PATCH 4/7] zram: align zcomp interface to crypto comp API Sergey Senozhatsky
2016-05-27 4:31 ` Minchan Kim
2016-05-27 8:00 ` Sergey Senozhatsky
2016-05-25 14:30 ` [PATCH 5/7] zram: use crypto api to check alg availability Sergey Senozhatsky
2016-05-27 4:43 ` Minchan Kim
2016-05-27 7:50 ` Sergey Senozhatsky
2016-05-27 8:27 ` Minchan Kim
2016-05-27 8:43 ` Herbert Xu
2016-05-27 9:04 ` Minchan Kim
2016-05-29 3:24 ` Sergey Senozhatsky
2016-05-30 4:47 ` Minchan Kim
2016-05-30 4:57 ` Sergey Senozhatsky
2016-05-25 14:30 ` [PATCH 6/7] zram: delete custom lzo/lz4 Sergey Senozhatsky
2016-05-25 14:30 ` [PATCH 7/7] zram: add more compression algorithms Sergey Senozhatsky
2016-05-26 0:43 ` [PATCH 0/7] zram: switch to crypto api Joonsoo Kim
2016-05-26 1:12 ` Sergey Senozhatsky
2016-05-26 1:52 ` Joonsoo Kim
2016-05-26 0:52 ` Minchan Kim [this message]
2016-05-26 1:08 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526005232.GD9661@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).