From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbcEZAxO (ORCPT ); Wed, 25 May 2016 20:53:14 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:47397 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbcEZAxN (ORCPT ); Wed, 25 May 2016 20:53:13 -0400 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 26 May 2016 09:52:32 +0900 From: Minchan Kim To: Sergey Senozhatsky CC: Andrew Morton , Joonsoo Kim , , Sergey Senozhatsky Subject: Re: [PATCH 0/7] zram: switch to crypto api Message-ID: <20160526005232.GD9661@bbox> References: <20160525143006.1207-1-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 In-Reply-To: <20160525143006.1207-1-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/05/26 09:52:12, Serialize by Router on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/05/26 09:52:12, Serialize complete at 2016/05/26 09:52:12 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 11:29:59PM +0900, Sergey Senozhatsky wrote: > Hello, > > This has started as a 'add zlib support' work, but after some > thinking I saw no blockers for a bigger change -- a switch to > crypto API. > > We don't have an idle zstreams list anymore and our write path > now works absolutely differently, preventing preemption during > compression. This removes possibilities of read paths preempting > writes at wrong places and opens the door for a move from custom > LZO/LZ4 compression backends implementation to a more generic one, > using crypto compress API. > > This patch set also eliminates the need of a new context-less > crypto API interface, which was quite hard to sell, so we can > move along faster. Super fast Sergey. At a first glance, patchset looks nice. I will review as soon as possible. Thanks a lot! > > > Sergey Senozhatsky (7): > zram: rename zstrm find-release functions > zram: switch to crypto compress API > zram: drop zcomp param from compress/decompress > zram: align zcomp interface to crypto comp API > zram: use crypto api to check alg availability > zram: delete custom lzo/lz4 > zram: add more compression algorithms > > drivers/block/zram/Kconfig | 15 +------ > drivers/block/zram/Makefile | 4 +- > drivers/block/zram/zcomp.c | 91 +++++++++++++++++++++++++++--------------- > drivers/block/zram/zcomp.h | 29 ++++---------- > drivers/block/zram/zcomp_lz4.c | 56 -------------------------- > drivers/block/zram/zcomp_lz4.h | 17 -------- > drivers/block/zram/zcomp_lzo.c | 56 -------------------------- > drivers/block/zram/zcomp_lzo.h | 17 -------- > drivers/block/zram/zram_drv.c | 26 +++++++----- > 9 files changed, 84 insertions(+), 227 deletions(-) > delete mode 100644 drivers/block/zram/zcomp_lz4.c > delete mode 100644 drivers/block/zram/zcomp_lz4.h > delete mode 100644 drivers/block/zram/zcomp_lzo.c > delete mode 100644 drivers/block/zram/zcomp_lzo.h > > -- > 2.8.3.394.g3916adf >