From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864AbcEZBHq (ORCPT ); Wed, 25 May 2016 21:07:46 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36648 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752558AbcEZBHo (ORCPT ); Wed, 25 May 2016 21:07:44 -0400 Date: Thu, 26 May 2016 10:07:34 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Joonsoo Kim , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 1/7] zram: rename zstrm find-release functions Message-ID: <20160526010734.GB532@swordfish> References: <20160525143006.1207-1-sergey.senozhatsky@gmail.com> <20160525143006.1207-2-sergey.senozhatsky@gmail.com> <20160526004412.GC9661@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160526004412.GC9661@bbox> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (05/26/16 09:44), Minchan Kim wrote: > On Wed, May 25, 2016 at 11:30:00PM +0900, Sergey Senozhatsky wrote: > > We don't perform any zstream idle list lookup anymore, so > > zcomp_strm_find()/zcomp_strm_release() names are not > > representative. > > > > Rename to zcomp_stream_get()/zcomp_stream_put(). > > Actually, I wanted it when we applied percpu but didn't say to you because > > 1. It's preference of author. > > Frankly speaking, I prefer get to find but you might think different > with me so I want to respect patch author's right if it's not huge pain > to me. :) > Now I realized you were on same page. > > 2. We might roll back to stream list. > > In that case, find is proper word again but it's too trivial. > So, I want to merge this patch regardless of this patchset. :) > > > > > Signed-off-by: Sergey Senozhatsky > > Cc: Minchan Kim > Acked-by: Minchan Kim thanks. -ss