From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016AbcEZCmR (ORCPT ); Wed, 25 May 2016 22:42:17 -0400 Received: from arcturus.aphlor.org ([188.246.204.175]:45896 "EHLO arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbcEZCmP (ORCPT ); Wed, 25 May 2016 22:42:15 -0400 Date: Wed, 25 May 2016 22:42:09 -0400 From: Dave Jones To: Linux Kernel Mailing List Cc: Gustavo Padovan , Daniel Vetter , Greg Kroah-Hartman Subject: Re: dma-buf/sync_file: de-stage sync_file Message-ID: <20160526024209.GA2840@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Linux Kernel Mailing List , Gustavo Padovan , Daniel Vetter , Greg Kroah-Hartman References: <20160521053153.14B99661B7C@gitolite.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160521053153.14B99661B7C@gitolite.kernel.org> User-Agent: Mutt/1.6.0 (2016-04-01) X-Spam-Flag: skipped (authorised relay user) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 21, 2016 at 05:31:53AM +0000, Linux Kernel wrote: > dma-buf/sync_file: de-stage sync_file > > sync_file is useful to connect one or more fences to the file. The file is > used by userspace to track fences between drivers that share DMA bufs. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Daniel Vetter > Signed-off-by: Greg Kroah-Hartman ... > +config SYNC_FILE > + bool "sync_file support for fences" > + default n > + select ANON_INODES > + select DMA_SHARED_BUFFER > + ---help--- > + This option enables the fence framework synchronization to export > + sync_files to userspace that can represent one or more fences. For such a generic sounding CONFIG_ item, this is one of the more obtuse descriptions in a kconfig we've had in a while, and the commit message doesn't give any more clues as to why anyone might want to enable this. I'm guessing this is some graphics thing given that Daniel reviewed it. >>From skimming the other commits, it seems to be some Android thing ? Are there depends missing perhaps that might make this more obvious ? Could you elaborate in the help text why someone might want to enable this ? As is, it's just a bunch of words with no context for anyone who isn't close to whatever domain this came from. Dave