From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754354AbcEZP1x (ORCPT ); Thu, 26 May 2016 11:27:53 -0400 Received: from mga02.intel.com ([134.134.136.20]:39071 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563AbcEZP1v (ORCPT ); Thu, 26 May 2016 11:27:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="989312315" Date: Thu, 26 May 2016 21:04:15 +0530 From: Vinod Koul To: Laurent Pinchart Cc: Kuninori Morimoto , Geert Uytterhoeven , Laurent Pinchart , sakato , OSD2 ML , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Message-ID: <20160526153414.GV2735@localhost> References: <87r3dywh6u.wl%kuninori.morimoto.gx@renesas.com> <20160514075731.GA23734@localhost> <2831766.dEtRrr4FvR@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2831766.dEtRrr4FvR@avalon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2016 at 12:50:28PM +0300, Laurent Pinchart wrote: Hey Laurent, > On Saturday 14 May 2016 13:27:31 Vinod Koul wrote: > > On Fri, Apr 22, 2016 at 01:50:04AM +0000, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > > > > Current rcar_dmac_desc_put() is using list_add_tail() in order to > > > push used descriptor to list of free descriptors, and next DMA transfer > > > try to reuse it from this list. But because it is using *_tail(), > > > this reuse effect can't be obtained without using all of them. > > > For a longer-term solution, we should allocate hardware descriptors > > > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today. > > > This patch uses list_add() instead of list_add_tail() for short-term > > > solution. > > > > Applied, thanks > > Thanks, but where did you apply it to ? I can't find it in your tree. I changed my mind after this and felt that we should document above in the changelog as well and replied to Kuninori few moments after this [1] Sorry if that wasn't clear that am not applying this. Please resend it with update changelog [1]: http://www.spinics.net/lists/dmaengine/msg09585.html -- ~Vinod