From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754836AbcEZSKc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 May 2016 14:10:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47920 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753400AbcEZSKb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 May 2016 14:10:31 -0400
Date: Thu, 26 May 2016 20:10:27 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, pi3orama@163.com, linux-kernel@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf ctf: Convert invalid chars in a string before set
 value
Message-ID: <20160526181027.GA21342@krava>
References: <1464172761-173095-1-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1464172761-173095-1-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 26 May 2016 18:10:30 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 25, 2016 at 10:39:21AM +0000, Wang Nan wrote:

SNIP

>  
> +static int string_set_value(struct bt_ctf_field *field, const char *string)
> +{
> +	char *buffer;
> +	size_t len = strlen(string), i, p;
> +	int err;
> +
> +	buffer = zalloc(len * 4 + 2);
> +	if (!buffer)
> +		return bt_ctf_field_string_set_value(field, string);

hope dies last ;-)

> +
> +	for (i = p = 0; i < len; i++) {
> +		if (isprint(string[i])) {
> +			buffer[p++] = string[i];
> +		} else {
> +			char numstr[5];
> +
> +			snprintf(numstr, sizeof(numstr), "\\x%02x",
> +				(unsigned int)(string[i]) & 0xff);
> +			strncat(buffer, numstr, 4);
> +			p = strlen(buffer);

			p += 4; instead ^^^ ?

other than that:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka