From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753961AbcE0E6Y (ORCPT ); Fri, 27 May 2016 00:58:24 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:49523 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbcE0E6X (ORCPT ); Fri, 27 May 2016 00:58:23 -0400 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.203 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Fri, 27 May 2016 13:43:43 +0900 From: Minchan Kim To: Sergey Senozhatsky CC: Andrew Morton , Joonsoo Kim , , Sergey Senozhatsky Subject: Re: [PATCH 5/7] zram: use crypto api to check alg availability Message-ID: <20160527044343.GE2322@bbox> References: <20160525143006.1207-1-sergey.senozhatsky@gmail.com> <20160525143006.1207-6-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 In-Reply-To: <20160525143006.1207-6-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB04/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/05/27 13:43:17, Serialize by Router on LGEKRMHUB04/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/05/27 13:43:17, Serialize complete at 2016/05/27 13:43:17 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sergey, I want to know more how it works so below questions goes. On Wed, May 25, 2016 at 11:30:04PM +0900, Sergey Senozhatsky wrote: > There is no way to get a string with all the crypto comp > algorithms supported by the crypto comp engine, so we need > to maintain our own backends list. At the same time we > additionally need to use crypto_has_comp() to make sure > that the user has requested a compression algorithm that is > recognized by the crypto comp engine. Relying on /proc/crypto > is not an options here, because it does not show not-yet-inserted > compression modules. > > Example: > > modprobe zram > cat /proc/crypto | grep -i lz4 > modprobe lz4 > cat /proc/crypto | grep -i lz4 > name : lz4 > driver : lz4-generic > module : lz4 > > So the user can't tell exactly if the lz4 is really supported > from /proc/crypto output, unless someone or something has loaded > it. > > This patch also adds crypto_has_comp() to zcomp_available_show(). crypto_has_comp works regardless of that whether module is loading or not? IOW, currently, if lz4 modules is not loading, but crypto_has_comp return true about lz4 module. Right? > We store all the compression algorithms names in zcomp's `backends' > array, regardless the CONFIG_CRYPTO_FOO configuration, but show Then, you mean we should add new string into backend array whenever adding new crypto compatible compression algorithm? > only those that are also supported by crypto engine. This helps > user to know the exact list of compression algorithms that can be > used. > > Example: > module lz4 is not loaded yet, but is supported by the crypto > engine. /proc/crypto has no information on this module, while > zram's `comp_algorithm' lists it: > > cat /proc/crypto | grep -i lz4 > > cat /sys/block/zram0/comp_algorithm > [lzo] lz4 deflate lz4hc 842 So, when lzo module is loading? > > Signed-off-by: Sergey Senozhatsky > Cc: Minchan Kim > Cc: Joonsoo Kim > --- > drivers/block/zram/zcomp.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c > index 79b30d7..a8593e9 100644 > --- a/drivers/block/zram/zcomp.c > +++ b/drivers/block/zram/zcomp.c > @@ -29,12 +29,16 @@ static const char * const backends[] = { > static const char *find_backend(const char *compress) > { > int i = 0; > + > while (backends[i]) { > if (sysfs_streq(compress, backends[i])) > break; > i++; > } > - return backends[i]; > + > + if (backends[i] && crypto_has_comp(backends[i], 0, 0)) > + return backends[i]; > + return NULL; > } > > static void zcomp_strm_free(struct zcomp *comp, struct zcomp_strm *zstrm) > @@ -74,14 +78,16 @@ ssize_t zcomp_available_show(const char *comp, char *buf) > ssize_t sz = 0; > int i = 0; > > - while (backends[i]) { > + for (; backends[i]; i++) { > + if (!crypto_has_comp(backends[i], 0, 0)) > + continue; > + > if (!strcmp(comp, backends[i])) > sz += scnprintf(buf + sz, PAGE_SIZE - sz - 2, > "[%s] ", backends[i]); > else > sz += scnprintf(buf + sz, PAGE_SIZE - sz - 2, > "%s ", backends[i]); > - i++; > } > sz += scnprintf(buf + sz, PAGE_SIZE - sz, "\n"); > return sz; > -- > 2.8.3.394.g3916adf >