From: Jiri Olsa <jolsa@redhat.com>
To: Hekuang <hekuang@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com,
namhyung@kernel.org, adrian.hunter@intel.com,
sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
tumanova@linux.vnet.ibm.com, kan.liang@intel.com,
penberg@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind
Date: Fri, 27 May 2016 10:44:48 +0200 [thread overview]
Message-ID: <20160527084448.GB23580@krava> (raw)
In-Reply-To: <5747FF33.3070906@huawei.com>
On Fri, May 27, 2016 at 04:02:59PM +0800, Hekuang wrote:
SNIP
> > > The only concern is that, if later we support more platforms,
> > > there will be too much files named as 'tools/perf/util/unwind-libunwind*.c'
> > > Is it acceptable or not?
> > >
> > > And I thought all files belongs to specific archs should
> > > go to folder under 'tools/perf/arch/xxx', is that right?
> > hum, I wouldn't worry about that.. but you're right,
> > let's put them under arch
>
> But only 'tools/perf/arch/$(host platform)' will be built, in our case,
> we should built the unwind-libunwind-$(arch) as long as we have
> the remote libunwind libraries. So, I think there's a conflict in the
> existing build script and not easy to 'put them under arch'. That's why
> I choose a complex way in my previous patch.
we dive into arch dirs via:
arch/Build:
libperf-y += $(ARCH)/
that's not changed AFAICS..
jirka
next prev parent reply other threads:[~2016-05-27 8:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 9:20 [PATCH v5 0/5] Add support for remote unwind He Kuang
2016-05-24 9:20 ` [PATCH v5 1/5] perf tools: Use LIBUNWIND_DIR for remote libunwind feature check He Kuang
2016-05-24 9:20 ` [PATCH v5 2/5] perf tools: Show warnings for unsupported cross-platform unwind He Kuang
2016-05-24 9:20 ` [PATCH v5 3/5] perf callchain: Add support for " He Kuang
2016-05-26 17:42 ` Jiri Olsa
2016-05-27 7:13 ` Hekuang
2016-05-27 7:38 ` Jiri Olsa
2016-05-27 8:02 ` Hekuang
2016-05-27 8:44 ` Jiri Olsa [this message]
2016-05-26 17:51 ` Jiri Olsa
2016-05-24 9:20 ` [PATCH v5 4/5] perf callchain: Support x86 target platform He Kuang
2016-05-26 17:57 ` Jiri Olsa
2016-05-24 9:20 ` [PATCH v5 5/5] perf callchain: Support aarch64 cross-platform He Kuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527084448.GB23580@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=jpoimboe@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tumanova@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox