From: "Pali Rohár" <pali.rohar@gmail.com>
To: Thorsten Leemhuis <fedora@leemhuis.info>
Cc: "Jan C Peters" <jcpeters89@gmail.com>,
"David Santamaría Rogado" <howl.nsp@gmail.com>,
"Peter Saunderson" <peteasa@gmail.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Tolga Cakir" <cevelnet@gmail.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dell-smm-hwmon: Cache fan_type() calls and use fan_status() for fan detection
Date: Fri, 27 May 2016 11:47:36 +0200 [thread overview]
Message-ID: <20160527094736.GL29844@pali> (raw)
In-Reply-To: <47313829-b0f7-9aca-443f-48ea2bdb7316@leemhuis.info>
On Friday 27 May 2016 10:00:05 Thorsten Leemhuis wrote:
> Pali Rohár wrote on 26.05.2016 17:51:
> > On Thursday 26 May 2016 17:39:57 Thorsten Leemhuis wrote:
> >> > I need to know if this patch fixes problem on Dell Studio XPS 8000
> >> > and Dell Studio XPS 8100 machines, so we can revert git commits:
> >> > 6220f4ebd7b4 ("hwmon: (dell-smm) Blacklist Dell Studio XPS 8000")
> >> > a4b45b25f18d ("hwmon: (dell-smm) Blacklist Dell Studio XPS 8100")
> >> Just checked: Sorry, that patch did not fix the CPU fan speed issue
> >> on my XPS 8000, so there is afaics no reason to revert 6220f4ebd7b4
> >> :-/
> > Please, can you apply patch "dell-smm-hwmon: In debug mode log duration
> > of SMM calls"
>
> On top of "Cache fan_type() calls and use fan_status() for fan
> detection" or with that patch reverted? I did the latter and
> tested with 4.6 (just mentioning it here in case it matters).
Ideally both.
> > and compile dell-smm-hwmon in debug mode to tell us which
> > SMM call takes too long? This is probably they key for that XPS
> > problems...
>
> [ 5.941037] dell_smm_hwmon: smm(0xfea3 0x0000) = 0x4147 (took 14470 usecs)
> [ 5.941139] dell_smm_hwmon: smm(0x11a3 0x0000) = 0xffff (took 93 usecs)
> [ 5.941236] dell_smm_hwmon: smm(0x11a3 0x0001) = 0xffff (took 93 usecs)
> [ 5.941331] dell_smm_hwmon: smm(0x11a3 0x0002) = 0xffff (took 92 usecs)
> [ 5.941427] dell_smm_hwmon: smm(0x11a3 0x0003) = 0xffff (took 92 usecs)
> [ 5.941526] dell_smm_hwmon: smm(0x03a3 0x0000) = 0x0000 (took 95 usecs)
> [ 5.941625] dell_smm_hwmon: smm(0x03a3 0x0001) = 0x0001 (took 95 usecs)
>
> HTH, CU, knurd
I do not see any long taking SMM call here. Are you really sure that
your machine freeze when loading or using dell-smm-hwmon?
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-05-27 9:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 14:46 [PATCH] dell-smm-hwmon: Cache fan_type() calls and use fan_status() for fan detection Pali Rohár
2016-05-22 0:19 ` Guenter Roeck
2016-05-22 0:28 ` Pali Rohár
2016-06-13 18:52 ` Pali Rohár
2016-06-14 2:02 ` Guenter Roeck
2016-06-15 8:03 ` Pali Rohár
2016-05-26 15:39 ` Thorsten Leemhuis
2016-05-26 15:51 ` Pali Rohár
2016-05-27 8:00 ` Thorsten Leemhuis
2016-05-27 9:47 ` Pali Rohár [this message]
2016-05-27 10:01 ` Thorsten Leemhuis
2016-05-27 10:45 ` Pali Rohár
2016-05-27 13:05 ` Thorsten Leemhuis
2016-05-27 13:21 ` Pali Rohár
2016-05-29 19:27 ` Peter Saunderson
2016-05-30 9:36 ` Pali Rohár
2016-05-30 16:25 ` Peter Saunderson
2016-06-02 13:06 ` Pali Rohár
2016-05-30 11:45 ` Thorsten Leemhuis
2016-06-13 18:30 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527094736.GL29844@pali \
--to=pali.rohar@gmail.com \
--cc=cevelnet@gmail.com \
--cc=fedora@leemhuis.info \
--cc=howl.nsp@gmail.com \
--cc=jcpeters89@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peteasa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).