From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbcE2C1i (ORCPT ); Sat, 28 May 2016 22:27:38 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35030 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbcE2C1h (ORCPT ); Sat, 28 May 2016 22:27:37 -0400 Date: Sun, 29 May 2016 12:24:58 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Herbert Xu , Sergey Senozhatsky , Sergey Senozhatsky , Andrew Morton , Joonsoo Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] zram: use crypto api to check alg availability Message-ID: <20160529032458.GA467@swordfish> References: <20160525143006.1207-1-sergey.senozhatsky@gmail.com> <20160525143006.1207-6-sergey.senozhatsky@gmail.com> <20160527044343.GE2322@bbox> <20160527075052.GB504@swordfish> <20160527082744.GH2322@bbox> <20160527084345.GA16022@gondor.apana.org.au> <20160527090438.GJ2322@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160527090438.GJ2322@bbox> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On (05/27/16 18:04), Minchan Kim wrote: > > It is fundamentally impossible to get a list of all *potential* > > algorithms if you allow loadable modules. By definition someone > > could load a new module and thus introduce a new algorithm. > > Thanks for the quick response. I understand now. > > Sergey, > > Then, shouldn't we add functionality to load new algorithm although > there is no entry in zcomp backend array? can do, sure: make find_backend() depend on crypto_has_comp() only, *may be* printk a message when we have a mismatch in backends array and crypto_has_comp(). but not really sure about the latter one. > The main reason we changed to crypto is to support various compression > algorithm for zram so we should be able to support anyone who want to > use custom crypto compression module. yes. > A idea is that let's not adding new compression string into backend > array from now on and deprecates /zram/comp_algorithm to show name. I'd really prefer not to deprecate /zram/comp_algorithm now. > So, from now on, users should be aware of the compression naming and > load module by oneself. It's not kind but I hope admins already knows > what cryto compressor they have. um, I'm not in love with this approach. what admins? zram users may be completely unaware of the existence of the crypto API and the kernel rebuild process. for some people switching to new zram will be a matter of "apt-get upgrade/pacman -Syu", not "git am ...; make menuconfig; make -j...". this looks like a major step back. keeping this dummy list of compressing backends around does not take a lot of effort, especially if we will make it unimportant for find_backend() and only use it for that nice user-friendly `cat /zram/comp_algorithm` output. -ss