From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932126AbcE2JLq (ORCPT ); Sun, 29 May 2016 05:11:46 -0400 Received: from mail-db3on0140.outbound.protection.outlook.com ([157.55.234.140]:22833 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932072AbcE2JLo (ORCPT ); Sun, 29 May 2016 05:11:44 -0400 Authentication-Results: cmpxchg.org; dkim=none (message not signed) header.d=none;cmpxchg.org; dmarc=none action=none header.from=virtuozzo.com; Date: Sun, 29 May 2016 12:11:33 +0300 From: Vladimir Davydov To: Johannes Weiner CC: Andrew Morton , Michal Hocko , , Subject: Re: [PATCH] mm: memcontrol: fix possible css ref leak on oom Message-ID: <20160529091133.GG26059@esperanza> References: <1464019330-7579-1-git-send-email-vdavydov@virtuozzo.com> <20160527173629.GE2531@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160527173629.GE2531@cmpxchg.org> X-Originating-IP: [81.5.99.64] X-ClientProxiedBy: VI1PR0901CA0078.eurprd09.prod.outlook.com (10.167.203.174) To VI1PR08MB0592.eurprd08.prod.outlook.com (10.163.169.22) X-MS-Office365-Filtering-Correlation-Id: 8ac1017c-0a20-429e-c336-08d387a13e77 X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0592;2:zW58VMwzKx4WjlydgBr2htuxCDH4EmSJF6+WJaCUWQks2weHm+meWPlDvoQHjjkwCJP2zY2EQVldVVvY9biEaHG/vjh5TJtRlkq0Ny5cyX6X+r8GxwQTFSFKU28wr0mpYW4F7O+Bmo1t11WpxJu5I+rlmhkvDAnCQem37RSChdj5M9G/TQIxGS38I7bjuNhE;3:eGSQI+oLxo6OLnwBOfApV7ZdxphW4UnXJBImIiI20kh0mSIcIJ121XiDpPPhee6WIDMAw51oWeeLfO68Q2SgGZJN14hyNOe2t9YQg1GNN+a+S8PtrdrDs4GCpdigaKqr X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB0592; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0592;25:vHwd9RcYpzXUvn5sn+rLFcu8klO8TJEWsyz7ZNzqXKt3bqhJJuW5naqg3keNhveUnY8xrKIAA0MBlU07A9NbmG0jQTQAjHQBjdUjYhZUH+ayjjg7lVyM2AfJ9CUrH5w6ycty1VYh53WQ3W+PA6jnCSUqGYw8Ew5VGN9WDzoufFBae6osHLEfPtOyqIqR9uK9b0MEmkIMz2RUp681j29D4oNAgf+gW+kEiYw/zxVKrktc2/rGc6fRgvsYU/vHurJQrR/xwrsEBAG+S1zQO/NA0oUiokimT9sJ2evarZBG+iO+XTFS2ZIlfCp00ATo0zyLk1xrdSei4a+BBc1R74ZqByvUkADp/KO4vO0PjvOQ3V0pLDdpnKt+n+NY3BSbnRNjih0K50yc7FVbwMI9qvPWoEJoKliNhxkfKTtoKD9JzzQmDsdrxgdhJUFaUUzB9dWvKPO2eyC66kcu6tVGYSBWQOAhjsaPQdNbNldsTuAPF3MSlPc6aiB6kjIHIO6kvQnuzhzo0ZrAXesBKhQCPNqvzCCETDE0YNmKJWJiAqcqfRnKs79OeXtrR3zeOgfTiAcgNssfzfuDRVyItEGqAz7VWEl4I9KLI58MeBMa+0BV8JJxslJwuYONu5FxbBpQBG1yoQJhoo8kPwhYD6hp4n5ngDb1X/JkrZczqOjnUDwHtiRHX/UbAxRVxBnWsgezvOwmgE6JJxNIJ5kDURn3N5Pxlw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:VI1PR08MB0592;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB0592; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0592;4:jw5JeEOHmmdo5amSUzZEhu9qcsoq3qiFGI6bz7SxDsqU6RJOzw9GOI6rXxys6G/px6MBT6aO5NClQRxULciHjbMEYzYxw+h8A5nhcTQ68uZSPHFRN7U7u0ZxEdfgCNqfjtdSsed6+M6DA1HRr9hVxMZVYiUqSFMjOQC8pytfNSj0D+zt71FZ4Tot+03Y0WCxxdvqFoKeNCfeBsFfgdjLQWc1bG7uztBPKX0/vth9Kx4TB1PdzL53FmfsYKjfnCsMWryGSm6HkElSVhQjaMYoyYwaIkEhrs+Uc9Snr25TCZhbxCqqFBRKAtMptM1ZnXBmDIVVPESu2mFsjpQAEAYu4CJuvkFSvfZFlHVAQHD89dnZdPpdPg68OQ17ZxDWnoqWPOsI80iinn+uvbo4LTyg69ACmSse2eLLU6ZNUGXp+4Y= X-Forefront-PRVS: 0957AD37A0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(24454002)(66066001)(50466002)(47776003)(3846002)(33656002)(4326007)(80792005)(50986999)(54356999)(76176999)(189998001)(23726003)(110136002)(6116002)(586003)(92566002)(46406003)(2906002)(1076002)(81166006)(8676002)(33716001)(77096005)(86362001)(5008740100001)(9686002)(2950100001)(42186005)(97756001)(5004730100002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR08MB0592;H:esperanza;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0592;23:N2ytWg6YiCPHHDP0D6fP/vSzic0Prmk1iTjtE/shH95nUltzCZZfuAjK/tOPJT9vEkHMu+XNcwqKpCN/fi4IJVjLO/a3wxXfB060G5VQ9KXEczRzID3U4e36XQchcEvqwPGqpjTQJkbhdyb9omyB2Fk0IfHsLlmBOnwDyVlJNQpsSfArP2pC2mx8uUgUmuYAipLxBL3IFkvPSvCG+qrksGc45wxgDJSdJ2trFq6Sx0ATWzI9RSCBWO7nu0q+lmBP09biV7hHYAXwvbGKbdegxVdYBew+ykIn/TJ3f0TIErHJJl61Ppx4xu04KxyNgQq9mhqWTQ+Q98eDSaSQpzbz2l3SYH51wzKFhvTAGgV+LSFgSx4ZMPmicZ2pVZbFmupF02BFYnUVBgWjZKcuTSKnA4HJtYHLbkrrL85xXqjmbz8oIAirnmssHpD9H9QLBfwKXGG7DJjvKKnNPwM89YGxXfHPIdHEregdkDGRqm+KAMGwYND462mQmhum/nx6hjQH24jVAbyN0mb6jXJOOKZgTADLEYsy3SRA67bfZPy+O3pQ2pjBSNL67L4GKd4cOMaNHXYwJDoWOcVjiPK7BEthThb/GTsZ7E2ZUZJO9qwiCVmy320o8w7O/VQHu3T6co7r0URUAOSW9mbMwpBURdQs8yb1BCit6CKvRHHnAf/ahUfsouIIDIhfMUWzw6iN/cggHZVEOy9+aDAwtPzMjxEndeO38BxMFmAKJ/OB2DuuZXOv0USQYqDHimsuE3tDMA+OSxp3X4VSo9vLgVALJyxqlCbY67iqJz1hAuOofuaKsVUL+aH2DusmbJnbE40xzLiD/nrpeuUEKnQsUXEoBr6fMGrDE3ea6z4nCLaQHRMqMooCWudxa+oQO+BVx/C2yRi9 X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0592;5:k/WpKa42SFu/AZ0ybzZsMZD6RYEUJoDIF62raU0nShazVWom67VMxPj4CdZ7vLC37dYKYXapns1HS1B+PibKVKsHl6TpCTmJ3+jw3p4bSaw82Ot3UWIS/njgpUsbzKt431N66BjIsRIwUd1WAZ5U3w==;24:0W1/OErb+Dy27L64rR7fqvAtSBQ0Ok+r++Nct6e7Dg3uxfu2J8c+4qoArDyb7fjwdyUGOKeOCefCMvuWEglhyM2gpmTJJ7EmiDZ/17RgvRI=;7:oi0v/iwh71SCrdd8GZ4QuFqTCoXmsKARTeYz76POq4yYlwM60svVKR5oPdvZah2EPfNMkRZGWoFFmvbbKmJH1CLQob6VodR/HmyblhJBHngVgOhTZfw0Co5D3UifdXKXOBWavryvzXQ4lrQQQsZ/9yqWLLDjDFqZG75ps37k5l2Xemkf84maOP9T8++UxruC;20:JQV3N5E5wS9Po37Moc9WqVDHtSBx0GuAHz83FMvyrLnx52zL0Lm4Hwf7ljgSW+V0Wo7jqc95V0owuJ9aLw8KPgqNJgvt5L0wFNu7/ruQTZwPvllOf13kE7y3V0IvhDlHCnsrgwIqXj3gpeW4rC94aQ9lZxppfZHVuoe6BNKvgIM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2016 09:11:39.1423 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0592 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 27, 2016 at 01:36:29PM -0400, Johannes Weiner wrote: > On Mon, May 23, 2016 at 07:02:10PM +0300, Vladimir Davydov wrote: > > mem_cgroup_oom may be invoked multiple times while a process is handling > > a page fault, in which case current->memcg_in_oom will be overwritten > > leaking the previously taken css reference. > > There is a task_in_memcg_oom() check before calling mem_cgroup_oom(). > > How can this happen? Oops, I overlooked that check. Scratch this patch then. Sorry for the noise.