From: Ralf Baechle <ralf@linux-mips.org>
To: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
"# 4 . 2 . x-" <stable@vger.kernel.org>
Subject: Re: [PATCH] MIPS: lib: Mark intrinsics notrace
Date: Sun, 29 May 2016 23:03:41 +0200 [thread overview]
Message-ID: <20160529210340.GA25587@linux-mips.org> (raw)
In-Reply-To: <20160525100635.22541-1-harvey.hunt@imgtec.com>
On Wed, May 25, 2016 at 11:06:35AM +0100, Harvey Hunt wrote:
> On certain MIPS32 devices, the ftrace tracer "function_graph" uses
> __lshrdi3() during the capturing of trace data. ftrace then attempts to
> trace __lshrdi3() which leads to infinite recursion and a stack overflow.
> Fix this by marking __lshrdi3() as notrace. Mark the other compiler
> intrinsics as notrace in case the compiler decides to use them in the
> ftrace path.
Makes perfect sense - but I'm wondering how you triggered it. Was this
a build with the GCC option -Os that is CONFIG_CC_OPTIMIZE_FOR_SIZE?
Usually people build with CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE that is -O2
which results in intrinsics being inlined.
Ralf
next prev parent reply other threads:[~2016-05-29 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 10:06 [PATCH] MIPS: lib: Mark intrinsics notrace Harvey Hunt
2016-05-29 21:03 ` Ralf Baechle [this message]
2016-05-31 12:18 ` Harvey Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160529210340.GA25587@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=harvey.hunt@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox