linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	dmaengine@vger.kernel.org, sakato <ryusuke.sakato.bx@renesas.com>,
	linux-kernel@vger.kernel.org, OSD2 ML <osd2@lm.renesas.com>
Subject: Re: [PATCH v2] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put()
Date: Mon, 30 May 2016 09:12:53 +0530	[thread overview]
Message-ID: <20160530034252.GF16910@localhost> (raw)
In-Reply-To: <877fecbcxh.wl%kuninori.morimoto.gx@renesas.com>

On Mon, May 30, 2016 at 12:41:48AM +0000, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> For each descriptor, in addition to the memory used by the descriptors
> structure itself, the driver allocates a list of chunks as well as a
> buffer for hardware descriptors. Descriptors themselves are preallocated,
> and allocation of the chunks and buffer is performed the first time the
> descriptor is used. The memory isn't freed when the transfer is completed,
> as the chunks and buffer will be needed again when the descriptor is
> reused internally, so the driver keeps the memory around.
> 
> If only a few descriptors are used concurrently, the current
> list_add_tail() implementation will result in all preallocated descriptors
> being used before going back to the first one, and will thus allocate
> chunks and a buffer for all preallocated descriptors. Using list_add()
> will put the complete descriptor at the head of the list of available
> descriptors, so the next transfer will be more likely to reuse a
> descriptor that already has associated memory instead of one that has
> never been used before.

Applied after fixing subsystem name

-- 
~Vinod

      reply	other threads:[~2016-05-30  3:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.journal-676557.20160325074450.6aeff6eaa5fae69d@dm.renesas.com>
     [not found] ` <8760w7xq3n.wl%kuninori.morimoto.gx@renesas.com>
     [not found]   ` <874mbrxnft.wl%kuninori.morimoto.gx@renesas.com>
     [not found]     ` <1645988.6VIRltF7C5@avalon>
2016-04-22  1:50       ` [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Kuninori Morimoto
2016-05-02  9:37         ` Vinod Koul
2016-05-09 20:49           ` Laurent Pinchart
2016-05-11  3:28             ` Kuninori Morimoto
2016-05-14  8:11               ` Vinod Koul
2016-05-14  7:57         ` Vinod Koul
2016-05-24  9:50           ` Laurent Pinchart
2016-05-26 15:34             ` Vinod Koul
2016-05-30  0:34               ` Kuninori Morimoto
2016-05-30  0:41       ` [PATCH v2] " Kuninori Morimoto
2016-05-30  3:42         ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160530034252.GF16910@localhost \
    --to=vinod.koul@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osd2@lm.renesas.com \
    --cc=ryusuke.sakato.bx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).