From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752010AbcE3E5u (ORCPT ); Mon, 30 May 2016 00:57:50 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36205 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbcE3E5t (ORCPT ); Mon, 30 May 2016 00:57:49 -0400 Date: Mon, 30 May 2016 13:57:23 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Herbert Xu , Sergey Senozhatsky , Andrew Morton , Joonsoo Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] zram: use crypto api to check alg availability Message-ID: <20160530045723.GA420@swordfish> References: <20160525143006.1207-1-sergey.senozhatsky@gmail.com> <20160525143006.1207-6-sergey.senozhatsky@gmail.com> <20160527044343.GE2322@bbox> <20160527075052.GB504@swordfish> <20160527082744.GH2322@bbox> <20160527084345.GA16022@gondor.apana.org.au> <20160527090438.GJ2322@bbox> <20160529032458.GA467@swordfish> <20160530044718.GC8683@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160530044718.GC8683@bbox> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Minchan, On (05/30/16 13:47), Minchan Kim wrote: [..] > > can do, sure: make find_backend() depend on crypto_has_comp() only, > > *may be* printk a message when we have a mismatch in backends array > > and crypto_has_comp(). but not really sure about the latter one. > > Me, too. We don't need to warn about that. Instead, we should allow loading > other algorithm which doesn't live in backend array more clearly. > We need to update documentation to clear it out. yes, entirely forgot to update the Documentation. > > > So, from now on, users should be aware of the compression naming and > > > load module by oneself. It's not kind but I hope admins already knows > > > what cryto compressor they have. > > > > um, I'm not in love with this approach. > > > > what admins? zram users may be completely unaware of the existence of > > the crypto API and the kernel rebuild process. for some people switching > > to new zram will be a matter of "apt-get upgrade/pacman -Syu", not > > "git am ...; make menuconfig; make -j...". this looks like a major step > > back. keeping this dummy list of compressing backends around does not take > > a lot of effort, especially if we will make it unimportant for find_backend() > > and only use it for that nice user-friendly `cat /zram/comp_algorithm` > > output. > > I am not against with it. Instead, please clear it out to write down docuement > "comp_algorithm is just optional so user can load any new algorithm like this > blah blah" ok, will do. thanks. -ss