From: Sebastian Reichel <sre@kernel.org>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HSI: cmt_speech: use vma_pages().
Date: Mon, 30 May 2016 07:13:20 +0200 [thread overview]
Message-ID: <20160530051320.GB21090@earth> (raw)
In-Reply-To: <1463836763-16758-1-git-send-email-falakreyaz@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
Hi,
On Sat, May 21, 2016 at 06:49:21PM +0530, Muhammad Falak R Wani wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/hsi/clients/cmt_speech.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c
> index 95638df..b16cfa4 100644
> --- a/drivers/hsi/clients/cmt_speech.c
> +++ b/drivers/hsi/clients/cmt_speech.c
> @@ -1275,7 +1275,7 @@ static int cs_char_mmap(struct file *file, struct vm_area_struct *vma)
> if (vma->vm_end < vma->vm_start)
> return -EINVAL;
>
> - if (((vma->vm_end - vma->vm_start) >> PAGE_SHIFT) != 1)
> + if (vma_pages(vma) != 1)
> return -EINVAL;
>
> vma->vm_flags |= VM_IO | VM_DONTDUMP | VM_DONTEXPAND;
Thanks, queued for 4.8.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-05-30 5:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 13:19 [PATCH] HSI: cmt_speech: use vma_pages() Muhammad Falak R Wani
2016-05-30 5:13 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530051320.GB21090@earth \
--to=sre@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=falakreyaz@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox