Re: [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins

Re: [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

On Thu, May 26, 2016 at 07:25:22PM -0000, Michal Suchanek wrote:
> Used on A10s Olinuxino.
> 
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>

Applied, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2/3] ARM: dts: sun5i: add spi2 on A10s Olinuxino Micro

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Hi,

On Thu, May 26, 2016 at 07:25:23PM -0000, Michal Suchanek wrote:
> spi2 is available on the UEXT connector
> 
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> ---
>  arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
> index 86d046a..7d2ff60 100644
> --- a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
> +++ b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
> @@ -192,6 +192,13 @@
>  	status = "okay";
>  };
>  
> +&spi2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi2_pins_a>,
> +		    <&spi2_cs0_pins_a>;
> +	status = "okay";
> +};
> +

This should be ordered alphabetically.

Fixed it, and applied.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 3/3] ARM: dts: sun5i: Add spi2 alias on A10s Olinuxino

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

On Thu, May 26, 2016 at 07:25:24PM -0000, Michal Suchanek wrote:
> spi2 is available on the UEXT connector
> 
> The bus is named spi2 in the A10s manual and Olinuxino manual so it is
> pointless to alias it to something else like spi0.

That's not how aliases work in the DT. It's about indexing the devices
that are enabled on the board, so it should definitely be 0,
especially since it's the only SPI bus usable on that board anyway.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]