From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932892AbcE3Iwu (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 May 2016 04:52:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46397 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932136AbcE3Iwt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 May 2016 04:52:49 -0400
Date: Mon, 30 May 2016 10:52:44 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
        jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com,
        namhyung@kernel.org, adrian.hunter@intel.com,
        sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
        tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org,
        dsahern@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 05/11] perf tools: Separate local/remote libunwind
 config
Message-ID: <20160530085244.GB25607@krava>
References: <1464436800-39860-1-git-send-email-hekuang@huawei.com>
 <1464436800-39860-6-git-send-email-hekuang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1464436800-39860-6-git-send-email-hekuang@huawei.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 30 May 2016 08:52:49 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 28, 2016 at 11:59:54AM +0000, He Kuang wrote:

SNIP

> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 6f9f566..3a304a3 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -354,10 +354,24 @@ ifeq ($(ARCH),powerpc)
>  endif
>  
>  ifndef NO_LIBUNWIND
> +  have_libunwind :=
>    ifneq ($(feature-libunwind), 1)
>      msg := $(warning No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR);
> +    NO_LOCAL_LIBUNWIND := 1
> +  else
> +    have_libunwind := 1
> +    CFLAGS += -DHAVE_LIBUNWIND_LOCAL_SUPPORT
> +    $(call detected,CONFIG_LOCAL_LIBUNWIND)
> +  endif
> +
> +  ifneq ($(have_libunwind), 1)
>      NO_LIBUNWIND := 1
> +  else
> +    CFLAGS += -I$(LIBUNWIND_DIR)/include
> +    LDFLAGS += -L$(LIBUNWIND_DIR)/lib

changelog says it's just switch, then why do we need to add above setup?

jirka