From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932988AbcE3IxS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 May 2016 04:53:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60046 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932961AbcE3IxQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 May 2016 04:53:16 -0400
Date: Mon, 30 May 2016 10:53:09 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
        jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com,
        namhyung@kernel.org, adrian.hunter@intel.com,
        sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
        tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org,
        dsahern@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 10/11] perf callchain: Support x86 target platform
Message-ID: <20160530085309.GE25607@krava>
References: <1464436800-39860-1-git-send-email-hekuang@huawei.com>
 <1464436800-39860-11-git-send-email-hekuang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1464436800-39860-11-git-send-email-hekuang@huawei.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 30 May 2016 08:53:15 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 28, 2016 at 11:59:59AM +0000, He Kuang wrote:

SNIP

> diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
> index b391e3e..849fec1 100644
> --- a/tools/perf/util/unwind-libunwind-local.c
> +++ b/tools/perf/util/unwind-libunwind-local.c
> @@ -5,7 +5,9 @@
>  #include <unistd.h>
>  #include <sys/mman.h>
>  #include <linux/list.h>
> +#ifndef REMOTE_UNWIND_LIBUNWIND
>  #include <libunwind.h>
> +#endif
>  #include "callchain.h"
>  #include "thread.h"
>  #include "session.h"
> @@ -671,7 +673,9 @@ _unwind_libunwind_ops = {
>  	.get_entries    = _unwind__get_entries,
>  };
>  
> +#ifndef REMOTE_UNWIND_LIBUNWIND
>  void register_local_unwind_libunwind_ops(struct thread *thread)
>  {
>  	thread->unwind_libunwind_ops = &_unwind_libunwind_ops;
>  }
> +#endif

above hunks should go to separate patch

however I still think it'd be more clear if we separate the code like:

code template		- util/unwind-libunwind.c
arch template		- arch/x86/util/unwind-libunwind.c

wrapper for local	- util/unwind-libunwind-local.c
wrapper for x86_32	- arch/x86/util/unwind-libunwind-x86_32.c
wrapper for arm64	- arch/x86/util/unwind-libunwind-arm64.c

jirka