From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933071AbcE3Ixi (ORCPT ); Mon, 30 May 2016 04:53:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48282 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933028AbcE3Ixd (ORCPT ); Mon, 30 May 2016 04:53:33 -0400 Date: Mon, 30 May 2016 10:53:17 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 10/11] perf callchain: Support x86 target platform Message-ID: <20160530085317.GF25607@krava> References: <1464436800-39860-1-git-send-email-hekuang@huawei.com> <1464436800-39860-11-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464436800-39860-11-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 30 May 2016 08:53:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 28, 2016 at 11:59:59AM +0000, He Kuang wrote: > Support x86(32-bit) cross platform callchain unwind. > > Signed-off-by: He Kuang > --- > tools/perf/arch/Build | 1 + > tools/perf/arch/x86/util/unwind-libunwind.c | 7 ++++--- > tools/perf/arch/x86/util/unwind-libunwind_x86_32.c | 21 +++++++++++++++++++++ > tools/perf/util/unwind-libunwind-local.c | 4 ++++ > tools/perf/util/unwind-libunwind.c | 19 +++++++++++++------ > tools/perf/util/unwind.h | 10 ++++++++++ > 6 files changed, 53 insertions(+), 9 deletions(-) > create mode 100644 tools/perf/arch/x86/util/unwind-libunwind_x86_32.c > > diff --git a/tools/perf/arch/Build b/tools/perf/arch/Build > index 109eb75..3fc4af1 100644 > --- a/tools/perf/arch/Build > +++ b/tools/perf/arch/Build > @@ -1,2 +1,3 @@ > libperf-y += common.o > libperf-y += $(ARCH)/ > +libperf-$(CONFIG_LIBUNWIND_X86) += x86/util/unwind-libunwind_x86_32.o we have Build file directly in arch/x86/util/ if you do it like this to include generic file easily we better fix the include then jirka