From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933039AbcE3Ixd (ORCPT ); Mon, 30 May 2016 04:53:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40077 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932978AbcE3Ix3 (ORCPT ); Mon, 30 May 2016 04:53:29 -0400 Date: Mon, 30 May 2016 10:53:24 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 03/11] perf tools: Introducing struct unwind_libunwind_ops for local unwind Message-ID: <20160530085324.GG25607@krava> References: <1464436800-39860-1-git-send-email-hekuang@huawei.com> <1464436800-39860-4-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464436800-39860-4-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 30 May 2016 08:53:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 28, 2016 at 11:59:52AM +0000, He Kuang wrote: > Currently, libunwind operations are fixed, and they are chosen > according to the host architecture. This will lead a problem that if a > thread is run as x86_32 on x86_64 machine, perf will use libunwind > methods for x86_64 to parse the callchain and get wrong result. > > This patch changes the fixed methods of libunwind operations to > thread/map related, and each thread can have indivadual libunwind > operations. Local libunwind methods are registered as default value. > > Signed-off-by: He Kuang > --- > tools/perf/util/thread.c | 2 ++ > tools/perf/util/thread.h | 14 +++++++++- > tools/perf/util/unwind-libunwind.c | 55 ++++++++++++++++++++++++++++++++++---- > tools/perf/util/unwind.h | 5 ++++ > 4 files changed, 70 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > index 45fcb71..6d3900c 100644 > --- a/tools/perf/util/thread.c > +++ b/tools/perf/util/thread.c > @@ -43,6 +43,8 @@ struct thread *thread__new(pid_t pid, pid_t tid) > thread->cpu = -1; > INIT_LIST_HEAD(&thread->comm_list); > > + register_local_unwind_libunwind_ops(thread); > + > if (unwind__prepare_access(thread) < 0) > goto err_thread; > > diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h > index aa3a8ff..647b011 100644 > --- a/tools/perf/util/thread.h > +++ b/tools/perf/util/thread.h > @@ -12,6 +12,17 @@ > > struct thread_stack; > > +struct unwind_entry; > +typedef int (*unwind_entry_cb_t)(struct unwind_entry *entry, void *arg); > +struct unwind_libunwind_ops { > + int (*prepare_access)(struct thread *thread); > + void (*flush_access)(struct thread *thread); > + void (*finish_access)(struct thread *thread); > + int (*get_entries)(unwind_entry_cb_t cb, void *arg, > + struct thread *thread, > + struct perf_sample *data, int max_stack); > +}; > + this should rather go to util/unwind.h thanks, jirka