From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754514AbcE3Jal (ORCPT ); Mon, 30 May 2016 05:30:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47927 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbcE3Jak (ORCPT ); Mon, 30 May 2016 05:30:40 -0400 Date: Mon, 30 May 2016 11:30:34 +0200 From: Jiri Olsa To: Hekuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 10/11] perf callchain: Support x86 target platform Message-ID: <20160530093034.GA9298@krava> References: <1464436800-39860-1-git-send-email-hekuang@huawei.com> <1464436800-39860-11-git-send-email-hekuang@huawei.com> <20160530085317.GF25607@krava> <574C03C7.9030807@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <574C03C7.9030807@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 30 May 2016 09:30:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 30, 2016 at 05:11:35PM +0800, Hekuang wrote: > hi > > 在 2016/5/30 16:53, Jiri Olsa 写道: > > On Sat, May 28, 2016 at 11:59:59AM +0000, He Kuang wrote: > > > Support x86(32-bit) cross platform callchain unwind. > > > > > > Signed-off-by: He Kuang > > > --- > > > tools/perf/arch/Build | 1 + > > > tools/perf/arch/x86/util/unwind-libunwind.c | 7 ++++--- > > > tools/perf/arch/x86/util/unwind-libunwind_x86_32.c | 21 +++++++++++++++++++++ > > > tools/perf/util/unwind-libunwind-local.c | 4 ++++ > > > tools/perf/util/unwind-libunwind.c | 19 +++++++++++++------ > > > tools/perf/util/unwind.h | 10 ++++++++++ > > > 6 files changed, 53 insertions(+), 9 deletions(-) > > > create mode 100644 tools/perf/arch/x86/util/unwind-libunwind_x86_32.c > > > > > > diff --git a/tools/perf/arch/Build b/tools/perf/arch/Build > > > index 109eb75..3fc4af1 100644 > > > --- a/tools/perf/arch/Build > > > +++ b/tools/perf/arch/Build > > > @@ -1,2 +1,3 @@ > > > libperf-y += common.o > > > libperf-y += $(ARCH)/ > > > +libperf-$(CONFIG_LIBUNWIND_X86) += x86/util/unwind-libunwind_x86_32.o > > we have Build file directly in arch/x86/util/ > > > > if you do it like this to include generic file easily > > we better fix the include then > > This is because "libperf-y += $(ARCH)" will only sink into $(ARCH) folder, > for example on x86_64, only tools/perf/arch/x86 will be built. But for > remote libunwind, we also need > 'tools/perf/arch/arm64/util/unwind-libunwind.o', while arm64 folder is > not added to libperf-y. Is there a gracefull to deal with this? you just need to include the file, right? I think it's ok to include arch/arm/....c from arch/x86/util/unwind-libunwind-arm64.c jirka