From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754568AbcE3JpD (ORCPT ); Mon, 30 May 2016 05:45:03 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35069 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752561AbcE3JpB (ORCPT ); Mon, 30 May 2016 05:45:01 -0400 Date: Mon, 30 May 2016 11:44:49 +0200 From: Maxime Ripard To: Michal Suchanek Cc: linux-sunxi@googlegroups.com, Mark Brown , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] spi: sunxi: fix transfer timeout Message-ID: <20160530094449.GJ4247@lukather> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GvznHscUikHnwW2p" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GvznHscUikHnwW2p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 26, 2016 at 07:25:23PM -0000, Michal Suchanek wrote: > The trasfer timeout is fixed at 1000 ms. Reading a 4Mbyte flash over > 1MHz SPI bus takes way longer than that. Calculate the timeout from the > actual time the transfer is supposed to take and multiply by 2 for good > measure. >=20 > Signed-off-by: Michal Suchanek > --- >=20 > v2: > - fix build error > - use unsigned instead of int in max_t And this generates warnings in checkpatch. Please make sure that you run it before submitting any patches. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --GvznHscUikHnwW2p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXTAuQAAoJEBx+YmzsjxAgyi8QAJJ5J/61o0a1Jaz42wiF17ki 0Q/ALGWTVhuDzF+CZOYLJfX2Q4icGOMxxCcIh8ECd9QencACaSC76gEO3qNy1n6p 1uqcj4U/oWX06sMiguv8nLDWR3/aUV04STiP8NeSa/crbkBqm79FtSn4p6qT7VYA 1JFxFOmcgkUE7VxLC0gOHa24zFEEoBJx/dSnSNqU5MFD596mtG/76YSgjWdpA6Eq hs5KeXiAUrt+3aGnZ58tWCvZlTr9S+tOqfUEM/H17SLpSaAD140eptalcXhmsohK DMSe40QfwGhgTVmeAadmGEc/pDH40Nm2svTQeEhwBRJ/8BsCma7zOc/An7Z8Nvjy xGvebw9mafX9oIAa8svz/qj7RY85eN4wqFl+n0gl6LUVeqA0tUZ2HMhWOyPRwDan recEqR3rHcquoRdhgOBZyR4v+S/Sfc9A4f1rAL2two2YGhZjhngbFJDhzWe2/AB+ 8jqhXHEWvTGY8zYpX0NZSl0PA++cUnKyxCrd/qhmoRKOz2Q6s3rAXkZF1rnHO5iD vQdQhWwn3ByqmqyAJL7sKNlzAgdvsC5NKRvr6mjcryeeAbDndnoKhnclI3ozvLS9 630XGTty5iioDCKwbXrURuXNhG8ijGbMhzF5Oursq+8FXX4VSAz+01mriJ2QvDKL r6amx3vcqseX0FU0ScMi =JJfV -----END PGP SIGNATURE----- --GvznHscUikHnwW2p--