From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933569AbcE3TfH (ORCPT ); Mon, 30 May 2016 15:35:07 -0400 Received: from mail.kernel.org ([198.145.29.136]:41739 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933361AbcE3TfF (ORCPT ); Mon, 30 May 2016 15:35:05 -0400 Date: Mon, 30 May 2016 16:35:00 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Alexander Shishkin , Masami Hiramatsu , Jiri Olsa Subject: Re: [PATCH v3 6/7] perf config: Remove needless code about config set at cmd_config() Message-ID: <20160530193500.GD2563@kernel.org> References: <1464626651-1523-1-git-send-email-treeze.taeung@gmail.com> <1464626651-1523-7-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464626651-1523-7-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, May 31, 2016 at 01:44:10AM +0900, Taeung Song escreveu: > show_config() was reimplemented using perf_config() > so it isn't needed to use perf_config_set__new() at cmd_config(). > And perf_config_set__delete() isn't needed at cmd_config() because of > calling the function at run_builtin() when a sub-command finished. > > And it isn't also needed to declare 'config_set' as extern variable > because the variable is only handled at util/config.c from now on. But the existing code looks more natural, i.e. before dealing with the config_set, we try instantiating it, handling errors at constructor calling time, etc. Then, finally, calling the destructor when we don't need it anymore. > Cc: Namhyung Kim > Cc: Jiri Olsa > Cc: Masami Hiramatsu > Cc: Alexander Shishkin > Signed-off-by: Taeung Song > --- > tools/perf/builtin-config.c | 8 -------- > tools/perf/util/config.h | 2 -- > 2 files changed, 10 deletions(-) > > diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c > index cf6c396..412c725 100644 > --- a/tools/perf/builtin-config.c > +++ b/tools/perf/builtin-config.c > @@ -64,12 +64,6 @@ int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused) > else if (use_user_config) > config_exclusive_filename = user_config; > > - config_set = perf_config_set__new(); > - if (!config_set) { > - ret = -1; > - goto out_err; > - } > - > switch (actions) { > case ACTION_LIST: > if (argc) { > @@ -90,7 +84,5 @@ int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused) > usage_with_options(config_usage, config_options); > } > > - perf_config_set__delete(); > -out_err: > return ret; > } > diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h > index e9b47b3..be4e603 100644 > --- a/tools/perf/util/config.h > +++ b/tools/perf/util/config.h > @@ -20,8 +20,6 @@ struct perf_config_set { > struct list_head sections; > }; > > -extern struct perf_config_set *config_set; > - > struct perf_config_set *perf_config_set__new(void); > void perf_config_set__delete(void); > > -- > 2.5.0