From: Yuyang Du <yuyang.du@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
umgwanakikbuti@gmail.com, bsegall@google.com, pjt@google.com,
morten.rasmussen@arm.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com
Subject: Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up
Date: Tue, 31 May 2016 09:31:32 +0800 [thread overview]
Message-ID: <20160531013132.GQ18670@intel.com> (raw)
In-Reply-To: <20160531092146.GT3192@twins.programming.kicks-ass.net>
On Tue, May 31, 2016 at 11:21:46AM +0200, Peter Zijlstra wrote:
> On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote:
> > The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals,
> > and in addition SD_BALANCE_WAKE is not and should not be set in any
> > sched_domain flags so far.
>
> This Changelog doesn't make any sense...
How? SD_BALANCE_WAKE is not in any sched_domain flags (sd->flags), even if
it is, it is not used anywhere, no?
> > Signed-off-by: Yuyang Du <yuyang.du@intel.com>
> > ---
> > kernel/sched/core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 7f2cae4..e00b8ea 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -6229,10 +6229,10 @@ static void set_domain_attribute(struct sched_domain *sd,
> > request = attr->relax_domain_level;
> > if (request < sd->level) {
> > /* turn off idle balance on this domain */
> > - sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> > + sd->flags &= ~(SD_BALANCE_NEWIDLE);
> > } else {
> > /* turn on idle balance on this domain */
> > - sd->flags |= (SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> > + sd->flags |= (SD_BALANCE_NEWIDLE);
> > }
> > }
> >
> > --
> > 1.7.9.5
> >
next prev parent reply other threads:[~2016-05-31 9:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 1:11 [RFC PATCH 0/2] Remove and replace SD_WAKE_AFFINE with SD_BALANCE_WAKE Yuyang Du
2016-05-31 1:11 ` [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Yuyang Du
2016-05-31 9:21 ` Peter Zijlstra
2016-05-31 1:31 ` Yuyang Du [this message]
2016-05-31 10:41 ` Peter Zijlstra
2016-05-31 18:00 ` Yuyang Du
2016-06-01 5:07 ` Mike Galbraith
2016-06-01 0:01 ` Yuyang Du
2016-06-01 8:32 ` Vincent Guittot
2016-06-01 1:03 ` Yuyang Du
2016-06-01 9:24 ` Vincent Guittot
2016-06-01 19:35 ` Yuyang Du
2016-06-02 6:56 ` Vincent Guittot
2016-06-01 23:19 ` Yuyang Du
2016-06-01 9:36 ` Mike Galbraith
2016-06-01 20:03 ` Yuyang Du
2016-06-02 5:50 ` Mike Galbraith
2016-06-01 22:41 ` Yuyang Du
2016-06-02 6:44 ` Mike Galbraith
2016-05-31 1:11 ` [RFC PATCH 2/2] sched: Remove SD_WAKE_AFFINE flag and replace it with SD_BALANCE_WAKE Yuyang Du
2016-05-31 9:23 ` Peter Zijlstra
2016-05-31 1:34 ` Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531013132.GQ18670@intel.com \
--to=yuyang.du@intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=umgwanakikbuti@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox