From: Peter Zijlstra <peterz@infradead.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf/x86/intel/rapl: add skylake server
Date: Tue, 31 May 2016 11:29:08 +0200 [thread overview]
Message-ID: <20160531092908.GV3192@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1464107503-14968-1-git-send-email-jacob.jun.pan@linux.intel.com>
On Tue, May 24, 2016 at 09:31:43AM -0700, Jacob Pan wrote:
> SKX uses similar RAPL interface as Broadwell server.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
> arch/x86/events/intel/rapl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/events/intel/rapl.c b/arch/x86/events/intel/rapl.c
> index 1705c9d..70af62a 100644
> --- a/arch/x86/events/intel/rapl.c
> +++ b/arch/x86/events/intel/rapl.c
> @@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void)
> break;
> case 63: /* Haswell-Server */
> case 79: /* Broadwell-Server */
> + case 85: /* Skylake-Server */
> apply_quirk = true;
> rapl_cntr_mask = RAPL_IDX_SRV;
> rapl_pmu_events_group.attrs = rapl_events_srv_attr;
This does not apply; please try against a more recent kernel. In
specific commit:
4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver modular")
seems to the 'problem'.
next prev parent reply other threads:[~2016-05-31 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 16:31 [PATCH] perf/x86/intel/rapl: add skylake server Jacob Pan
2016-05-31 9:29 ` Peter Zijlstra [this message]
2016-06-01 18:05 ` jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531092908.GV3192@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=eranian@google.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox