From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757078AbcEaJ3P (ORCPT ); Tue, 31 May 2016 05:29:15 -0400 Received: from merlin.infradead.org ([205.233.59.134]:48064 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756869AbcEaJ3M (ORCPT ); Tue, 31 May 2016 05:29:12 -0400 Date: Tue, 31 May 2016 11:29:08 +0200 From: Peter Zijlstra To: Jacob Pan Cc: LKML , Srinivas Pandruvada , Thomas Gleixner , Stephane Eranian Subject: Re: [PATCH] perf/x86/intel/rapl: add skylake server Message-ID: <20160531092908.GV3192@twins.programming.kicks-ass.net> References: <1464107503-14968-1-git-send-email-jacob.jun.pan@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464107503-14968-1-git-send-email-jacob.jun.pan@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2016 at 09:31:43AM -0700, Jacob Pan wrote: > SKX uses similar RAPL interface as Broadwell server. > > Signed-off-by: Jacob Pan > --- > arch/x86/events/intel/rapl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/events/intel/rapl.c b/arch/x86/events/intel/rapl.c > index 1705c9d..70af62a 100644 > --- a/arch/x86/events/intel/rapl.c > +++ b/arch/x86/events/intel/rapl.c > @@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void) > break; > case 63: /* Haswell-Server */ > case 79: /* Broadwell-Server */ > + case 85: /* Skylake-Server */ > apply_quirk = true; > rapl_cntr_mask = RAPL_IDX_SRV; > rapl_pmu_events_group.attrs = rapl_events_srv_attr; This does not apply; please try against a more recent kernel. In specific commit: 4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver modular") seems to the 'problem'.