From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753604AbcEaMg2 (ORCPT ); Tue, 31 May 2016 08:36:28 -0400 Received: from mga11.intel.com ([192.55.52.93]:38050 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929AbcEaMg0 (ORCPT ); Tue, 31 May 2016 08:36:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,395,1459839600"; d="scan'208";a="711552971" Date: Tue, 31 May 2016 15:36:22 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, open list Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Message-ID: <20160531123622.GT4329@intel.com> References: <1464691994-5704-1-git-send-email-kraxel@redhat.com> <1464691994-5704-5-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1464691994-5704-5-git-send-email-kraxel@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 12:53:12PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/drm_crtc.c | 2 ++ > include/drm/drm_crtc.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index d2a6d95..ce5a280 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -2977,6 +2977,8 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc, > DRM_DEBUG_KMS("failed to wrap cursor buffer in drm framebuffer\n"); > return PTR_ERR(fb); > } > + fb->hot_x = req->hot_x; > + fb->hot_y = req->hot_y; > } else { > fb = NULL; > } > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index d1559cd..1460f66 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -253,6 +253,8 @@ struct drm_framebuffer { > int bits_per_pixel; > int flags; > uint32_t pixel_format; /* fourcc format */ > + int hot_x; > + int hot_y; > struct list_head filp_head; > }; Why store it in the fb and not eg. the plane state? > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC