Re: [PATCH 6/8] mfd: ti_am335x_tscadc: use variable name for sizeof() operator

Lee Jones
2016-06-08T15:35:11Z

On Tue, 31 May 2016, Andrew F. Davis wrote:

> Fix the code formatting to use the kernel preferred style
> of using the actual variables to determize the size using
> the sizeof() operator.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> drivers/mfd/ti_am335x_tscadc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> index d30bea5..c8f027b 100644
> --- a/drivers/mfd/ti_am335x_tscadc.c
> +++ b/drivers/mfd/ti_am335x_tscadc.c
> @@ -168,8 +168,7 @@ static int ti_tscadc_probe(struct platform_device *pdev)
> }
>
> /* Allocate memory for device */
> - tscadc = devm_kzalloc(&pdev->dev,
> - sizeof(struct ti_tscadc_dev), GFP_KERNEL);
> + tscadc = devm_kzalloc(&pdev->dev, sizeof(*tscadc), GFP_KERNEL);
> if (!tscadc) {
> dev_err(&pdev->dev, "failed to allocate memory.\n");
> return -ENOMEM;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog