From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754855AbcEaVZW (ORCPT ); Tue, 31 May 2016 17:25:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46666 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbcEaVZV (ORCPT ); Tue, 31 May 2016 17:25:21 -0400 Date: Tue, 31 May 2016 23:25:17 +0200 From: Oleg Nesterov To: Michal Hocko Cc: Andrew Morton , Tetsuo Handa , David Rientjes , linux-mm@kvack.org, LKML , Michal Hocko Subject: Re: [PATCH] mm, oom_reaper: do not use siglock in try_oom_reaper Message-ID: <20160531212517.GA26582@redhat.com> References: <1464679423-30218-1-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464679423-30218-1-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 31 May 2016 21:25:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31, Michal Hocko wrote: > > @@ -636,10 +634,7 @@ void try_oom_reaper(struct task_struct *tsk) > * If the task is exiting make sure the whole thread group > * is exiting and cannot acces mm anymore. > */ > - spin_lock_irq(&p->sighand->siglock); > - exiting = signal_group_exit(p->signal); > - spin_unlock_irq(&p->sighand->siglock); > - if (exiting) > + if (signal_group_exit(p->signal)) > continue; Yes, thanks Michal. signal_group_exit() is not really right too (coredump) but this is not that important and you are going to rework this code anyway. Oleg.