From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757231AbcFACeR (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 May 2016 22:34:17 -0400
Received: from e18.ny.us.ibm.com ([129.33.205.208]:51089 "EHLO
	e18.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757222AbcFACeN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 May 2016 22:34:13 -0400
X-IBM-Helo: d01dlp01.pok.ibm.com
X-IBM-MailFrom: paulmck@linux.vnet.ibm.com
X-IBM-RcptTo: linux-kernel@vger.kernel.org
Date: Tue, 31 May 2016 19:34:13 -0700
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Daniel Bristot de Oliveira <daolivei@redhat.com>
Cc: Josh Triplett <josh@joshtriplett.org>, linux-kernel@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>, Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Subject: Re: [RFC PATCH 1/2] rcu: sysctl: Panic on RCU Stall
Message-ID: <20160601023413.GV4337@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <cover.1464652607.git.bristot@redhat.com>
 <fba2e213f572f16d8915d709f19c368f04ebdb93.1464652607.git.bristot@redhat.com>
 <20160531191827.GA4574@x>
 <20160531192325.GA4851@x>
 <dd23c6b6-e2f7-de14-9922-863223f7c6f7@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dd23c6b6-e2f7-de14-9922-863223f7c6f7@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16060102-0045-0000-0000-000004570BB4
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 31, 2016 at 07:49:41PM -0300, Daniel Bristot de Oliveira wrote:
> On 05/31/2016 04:23 PM, Josh Triplett wrote:
> 
> Hi Josh,
> 
> > Sorry, realized something else a moment after sending: I don't think
> > this will build if you use the tiny RCU implementation.  That
> > implementation *does* support tracing, and if you enable tracing,
> > you'll have CONFIG_RCU_STALL_COMMON=y, but you won't build tree.c where
> > the variable definition lives.  So, the sysctl code will reference a
> > variable that doesn't exist.
> 
> Good catch!
> 
> [root@f23 linux]# egrep '(TINY_RCU|RCU_TRACE)' .config
> CONFIG_TINY_RCU=y
> # CONFIG_TREE_RCU_TRACE is not set
> CONFIG_RCU_TRACE=y
> [root@f23 linux]# make
> ...
> kernel/built-in.o:(.data+0x4688): undefined reference to `sysctl_panic_on_rcu_stall'
> Makefile:937: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> 
> How about this change in the condition:
> -#ifdef CONFIG_RCU_STALL_COMMON
> +#if defined(CONFIG_TREE_RCU) || defined(CONFIG_PREEMPT_RCU)

Looks plausible to me.  But what I would trust quite a bit more than my
own opinion would be successful builds for all three configurations.  ;-)

							Thanx, Paul

> It worked fine here, but I may be missing something, so I better
> check with the experts :-).
> 
> Thanks for reviewing the patch set!
> 
> -- Daniel
>