From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758233AbcFAIj5 (ORCPT ); Wed, 1 Jun 2016 04:39:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52527 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754028AbcFAIjy (ORCPT ); Wed, 1 Jun 2016 04:39:54 -0400 Date: Wed, 1 Jun 2016 10:39:49 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 03/14] perf tools: Introducing struct unwind_libunwind_ops for local unwind Message-ID: <20160601083949.GD13738@krava> References: <1464693552-104294-1-git-send-email-hekuang@huawei.com> <1464693552-104294-4-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464693552-104294-4-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 01 Jun 2016 08:39:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 11:19:01AM +0000, He Kuang wrote: > Currently, libunwind operations are fixed, and they are chosen > according to the host architecture. This will lead a problem that if a > thread is run as x86_32 on x86_64 machine, perf will use libunwind > methods for x86_64 to parse the callchain and get wrong result. > > This patch changes the fixed methods of libunwind operations to > thread/map related, and each thread can have indivadual libunwind > operations. Local libunwind methods are registered as default value. > > Signed-off-by: He Kuang > --- > tools/perf/util/thread.c | 6 ++++ > tools/perf/util/thread.h | 4 ++- > tools/perf/util/unwind-libunwind.c | 58 +++++++++++++++++++++++++++++++++++--- > tools/perf/util/unwind.h | 19 +++++++++++++ > 4 files changed, 82 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > index 45fcb71..95ff1b8 100644 > --- a/tools/perf/util/thread.c > +++ b/tools/perf/util/thread.c > @@ -43,6 +43,12 @@ struct thread *thread__new(pid_t pid, pid_t tid) > thread->cpu = -1; > INIT_LIST_HEAD(&thread->comm_list); > > +#ifdef HAVE_LIBUNWIND_SUPPORT > + unwind__register_ops(thread, local_unwind_libunwind_ops); > +#else > + unwind__register_ops(thread, NULL); > +#endif > + I think we should put unwind__register_ops call into unwind__prepare_access in this patch (like you do in patch 4) and without the #else clause this way you can keep unwind__register_ops local thanks, jirka