From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758264AbcFAIkf (ORCPT ); Wed, 1 Jun 2016 04:40:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52675 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758249AbcFAIkc (ORCPT ); Wed, 1 Jun 2016 04:40:32 -0400 Date: Wed, 1 Jun 2016 10:40:27 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 13/14] perf callchain: Support x86 target platform Message-ID: <20160601084027.GG13738@krava> References: <1464693552-104294-1-git-send-email-hekuang@huawei.com> <1464693552-104294-14-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464693552-104294-14-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 01 Jun 2016 08:40:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 11:19:11AM +0000, He Kuang wrote: SNIP > diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c > index e183390..5774317 100644 > --- a/tools/perf/util/unwind-libunwind.c > +++ b/tools/perf/util/unwind-libunwind.c > @@ -5,6 +5,7 @@ > #include "arch/common.h" > > struct unwind_libunwind_ops __weak *local_unwind_libunwind_ops; > +struct unwind_libunwind_ops __weak *x86_32_unwind_libunwind_ops; > > void unwind__register_ops(struct thread *thread, > struct unwind_libunwind_ops *ops) > @@ -30,7 +31,13 @@ int unwind__prepare_access(struct thread *thread, struct map *map) > dso_type == DSO__TYPE_64BIT, map->dso->name); > > arch = normalize_arch(thread->mg->machine->env->arch); > - pr_debug("unwind: target platform=%s\n", arch); > + > + if (!strcmp(arch, "x86")) > + if (dso_type != DSO__TYPE_64BIT) > + ops = x86_32_unwind_libunwind_ops; > + > + if (!ops) > + pr_err("unwind: target platform=%s is not supported\n", arch); how could ops become NULL in here? it starts with local_unwind_libunwind_ops I dont think this check is needed in here jirka