From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758334AbcFAIlJ (ORCPT ); Wed, 1 Jun 2016 04:41:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52759 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758318AbcFAIlF (ORCPT ); Wed, 1 Jun 2016 04:41:05 -0400 Date: Wed, 1 Jun 2016 10:41:00 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 13/14] perf callchain: Support x86 target platform Message-ID: <20160601084100.GJ13738@krava> References: <1464693552-104294-1-git-send-email-hekuang@huawei.com> <1464693552-104294-14-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464693552-104294-14-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 01 Jun 2016 08:41:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 11:19:11AM +0000, He Kuang wrote: SNIP > diff --git a/tools/perf/util/libunwind/x86_32.c b/tools/perf/util/libunwind/x86_32.c > new file mode 100644 > index 0000000..46b4111 > --- /dev/null > +++ b/tools/perf/util/libunwind/x86_32.c > @@ -0,0 +1,18 @@ > +#define REMOTE_UNWIND_LIBUNWIND > + > +#define LIBUNWIND__ARCH_REG_ID libunwind__x86_reg_id > + > +#include "unwind.h" > +#include "debug.h" > +#include "libunwind-x86.h" > +#include <../../../../arch/x86/include/uapi/asm/perf_regs.h> > + > +#undef HAVE_ARCH_X86_64_SUPPORT > +#include "../../arch/x86/util/unwind-libunwind.c" > + > +#undef NO_LIBUNWIND_DEBUG_FRAME > +#define NO_LIBUNWIND_DEBUG_FRAME so debug_frame is explicitly switched off for remote unwind? 2 things: - could we have some comments/reasonning for un/setting defines in here (and the other arch files) - could you please use the #ifndef XXX #define XXX #endif way thanks, jirka