From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758260AbcFAQtm (ORCPT ); Wed, 1 Jun 2016 12:49:42 -0400 Received: from tex.lwn.net ([70.33.254.29]:36710 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753077AbcFAQtj (ORCPT ); Wed, 1 Jun 2016 12:49:39 -0400 Date: Wed, 1 Jun 2016 10:49:37 -0600 From: Jonathan Corbet To: Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 7/8] pkeys: add details of system call use to Documentation/ Message-ID: <20160601104937.098a89a2@lwn.net> In-Reply-To: <574F114F.8010701@sr71.net> References: <20160531152814.36E0B9EE@viggo.jf.intel.com> <20160531152824.2B18E890@viggo.jf.intel.com> <20160601104333.7c2014fa@lwn.net> <574F114F.8010701@sr71.net> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Jun 2016 09:46:07 -0700 Dave Hansen wrote: > On 06/01/2016 09:43 AM, Jonathan Corbet wrote: > >> > +There are 5 system calls which directly interact with pkeys: > >> > + > >> > + int pkey_alloc(unsigned long flags, unsigned long init_access_rights) > >> > + int pkey_free(int pkey); > >> > + int sys_pkey_mprotect(unsigned long start, size_t len, > >> > + unsigned long prot, int pkey); > >> > + unsigned long pkey_get(int pkey); > >> > + int pkey_set(int pkey, unsigned long access_rights); > > sys_pkey_mprotect() should just be pkey_mprotect(), right? > > Yes, and that are a few more instances of that farther down in the file. > I'll fix them all up. While you're at it (I shouldn't have hit send quite so quickly :) > + sys_pkey_alloc(0, PKEY_DISABLE_WRITE | PKEY_DISABLE_READ); > + sys_pkey_mprotect(ptr, size, PROT_READ|PROT_WRITE); > + something(ptr); That should, IMO, be something like: key = pkey_alloc(...); pkey_mprotect(ptr, size, PROT_READ|PROT_WRITE, key); ? jon