* [PATCH] perf/x86/intel/rapl: add skylake server
@ 2016-05-24 16:31 Jacob Pan
2016-05-31 9:29 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Jacob Pan @ 2016-05-24 16:31 UTC (permalink / raw)
To: LKML, Peter Zijlstra
Cc: Srinivas Pandruvada, Thomas Gleixner, Stephane Eranian, Jacob Pan
SKX uses similar RAPL interface as Broadwell server.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
arch/x86/events/intel/rapl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/events/intel/rapl.c b/arch/x86/events/intel/rapl.c
index 1705c9d..70af62a 100644
--- a/arch/x86/events/intel/rapl.c
+++ b/arch/x86/events/intel/rapl.c
@@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void)
break;
case 63: /* Haswell-Server */
case 79: /* Broadwell-Server */
+ case 85: /* Skylake-Server */
apply_quirk = true;
rapl_cntr_mask = RAPL_IDX_SRV;
rapl_pmu_events_group.attrs = rapl_events_srv_attr;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/x86/intel/rapl: add skylake server
2016-05-24 16:31 [PATCH] perf/x86/intel/rapl: add skylake server Jacob Pan
@ 2016-05-31 9:29 ` Peter Zijlstra
2016-06-01 18:05 ` jacob
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2016-05-31 9:29 UTC (permalink / raw)
To: Jacob Pan; +Cc: LKML, Srinivas Pandruvada, Thomas Gleixner, Stephane Eranian
On Tue, May 24, 2016 at 09:31:43AM -0700, Jacob Pan wrote:
> SKX uses similar RAPL interface as Broadwell server.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
> arch/x86/events/intel/rapl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/events/intel/rapl.c b/arch/x86/events/intel/rapl.c
> index 1705c9d..70af62a 100644
> --- a/arch/x86/events/intel/rapl.c
> +++ b/arch/x86/events/intel/rapl.c
> @@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void)
> break;
> case 63: /* Haswell-Server */
> case 79: /* Broadwell-Server */
> + case 85: /* Skylake-Server */
> apply_quirk = true;
> rapl_cntr_mask = RAPL_IDX_SRV;
> rapl_pmu_events_group.attrs = rapl_events_srv_attr;
This does not apply; please try against a more recent kernel. In
specific commit:
4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver modular")
seems to the 'problem'.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf/x86/intel/rapl: add skylake server
2016-05-31 9:29 ` Peter Zijlstra
@ 2016-06-01 18:05 ` jacob
0 siblings, 0 replies; 3+ messages in thread
From: jacob @ 2016-06-01 18:05 UTC (permalink / raw)
To: Peter Zijlstra
Cc: LKML, Srinivas Pandruvada, Thomas Gleixner, Stephane Eranian,
Dave Hansen
On Tue, 31 May 2016 11:29:08 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> > case 63: /* Haswell-Server */
> > case 79: /* Broadwell-Server */
> > + case 85: /* Skylake-Server */
> > apply_quirk = true;
> > rapl_cntr_mask = RAPL_IDX_SRV;
> > rapl_pmu_events_group.attrs =
> > rapl_events_srv_attr;
>
> This does not apply; please try against a more recent kernel. In
> specific commit:
>
> 4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver
> modular")
>
> seems to the 'problem'.
Dave Hanse (cc'd) will send out the patch as part of the clean up of
open-coding x86 model numbers.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-01 18:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-24 16:31 [PATCH] perf/x86/intel/rapl: add skylake server Jacob Pan
2016-05-31 9:29 ` Peter Zijlstra
2016-06-01 18:05 ` jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox